Prev: nilfs2: fix sync silent failure
Next: trivial:Fix some comments.
From: Nick Cheng on 3 May 2010 09:20
Hi James,
It seems you set CONFIG_SCSI_ARCMSR_AER.
Could you undefine it?
I will remove this section.
-----Original Message-----
From: James Bottomley [mailto:James.Bottomley(a)suse.de]
Sent: Monday, May 03, 2010 9:00 PM
To: nick.cheng(a)areca.com.tw
Cc: linux-scsi(a)vger.kernel.org; linux-kernel(a)vger.kernel.org
Subject: Re: [PATCH 1/3 ] SCSI: Support HW reset for EH and polling scheme
for scsi device(This is correct revision, please ignore last one)

On Mon, 2010-05-03 at 15:45 +0800, Nick Cheng wrote:
> 1. To support instantaneous report for SCSI device existing by periodic
> polling
> 2. In arcmsr_iop_xfer(), inform AP of F/W's deadlock state to prevent
> endless waiting
> 3. To block the coming SCSI command while the driver is handling bus reset
> 4. To support HW reset in bus reset error handler
> Signed-off-by: Nick Cheng< nick.cheng(a)areca.com.tw >

This patch still isn't compiling:

CC [M] drivers/scsi/arcmsr/arcmsr_hba.o
drivers/scsi/arcmsr/arcmsr_hba.c: In function 'arcmsr_pci_slot_reset':
drivers/scsi/arcmsr/arcmsr_hba.c:2733: error: too few arguments to
function 'arcmsr_get_firmware_spec'
make[1]: *** [drivers/scsi/arcmsr/arcmsr_hba.o] Error 1
make: *** [drivers/scsi/arcmsr/arcmsr.ko] Error 2

It looks like you missed converting one of the
arcmsr_get_firmware_spec() to the two argument prototype.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Nick Cheng on 3 May 2010 09:30
It seems I have to remove this section first then make a new patch for you.
I will email the patches to you tomorrow.
Thanks,
-----Original Message-----
From: James Bottomley [mailto:James.Bottomley(a)suse.de]
Sent: Monday, May 03, 2010 9:25 PM
To: nick.cheng(a)areca.com.tw
Cc: linux-scsi(a)vger.kernel.org; linux-kernel(a)vger.kernel.org
Subject: RE: [PATCH 1/3 ] SCSI: Support HW reset for EH and polling scheme
for scsi device(This is correct revision, please ignore last one)

On Mon, 2010-05-03 at 21:17 +0800, Nick Cheng wrote:
> Hi James,
> It seems you set CONFIG_SCSI_ARCMSR_AER.
> Could you undefine it?

Config option testing is part of the stuff I run through. Even if I
undefine it, one of the many people who run automated config testing
will pick it up ... and then I'll get email about it.

> I will remove this section.

Thanks.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: nilfs2: fix sync silent failure
Next: trivial:Fix some comments.