SCSI: fix bio.bi_rw handling
in [Kernel]
|
Prev: BLOCK: fix bio.bi_rw handling
Next: [PATCH]: local_irq_save/restore when issuing IPI in early bootup
From: Jeff Moyer on 12 Aug 2010 09:40 Jiri Slaby <jslaby(a)suse.cz> writes: > Return of the bi_rw tests is no longer bool after commit 74450be1. So > testing against constants doesn't make sense anymore. Fix this bug in > osd_req_read by removing "== 1" in test. > > This is not a problem now, where REQ_WRITE is 1, but this can change > in the future and we don't want to rely on that. > > Signed-off-by: Jiri Slaby <jslaby(a)suse.cz> > Cc: "James E.J. Bottomley" <James.Bottomley(a)suse.de> > Cc: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Jeff Moyer <jmoyer(a)redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Hellwig on 12 Aug 2010 12:10
On Thu, Aug 12, 2010 at 02:31:05PM +0200, Jiri Slaby wrote: > Return of the bi_rw tests is no longer bool after commit 74450be1. So > testing against constants doesn't make sense anymore. Fix this bug in > osd_req_read by removing "== 1" in test. > > This is not a problem now, where REQ_WRITE is 1, but this can change > in the future and we don't want to rely on that. And it's much cleaner anyway. Note that I think we particularly need the WARN_ON anyway. Reviewed-by: Christoph Hellwig <hch(a)lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |