Prev: NET: netpoll, fix potential NULL ptr dereference
Next: [PATCH] exit: fix oops in sync_mm_rss
From: James Smart on 16 Mar 2010 13:20
Acked-By: James Smart <james.smart(a)emulex.com>

-- james s


Jiri Slaby wrote:
> Stanse found that two error paths in lpfc_bsg_rport_els_cmp and
> lpfc_issue_ct_rsp_cmp omits to unlock phba->ct_ev_lock. It is
> because they wrongly unlock phba->hbalock instead. Fix that.
>
> Signed-off-by: Jiri Slaby <jslaby(a)suse.cz>
> Cc: James Smart <james.smart(a)emulex.com>
> Cc: James Bottomley <James.Bottomley(a)suse.de>
> ---
> drivers/scsi/lpfc/lpfc_bsg.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
> index 692c29f..992efb1 100644
> --- a/drivers/scsi/lpfc/lpfc_bsg.c
> +++ b/drivers/scsi/lpfc/lpfc_bsg.c
> @@ -432,7 +432,7 @@ lpfc_bsg_rport_els_cmp(struct lpfc_hba *phba,
> dd_data = cmdiocbq->context1;
> /* normal completion and timeout crossed paths, already done */
> if (!dd_data) {
> - spin_unlock_irqrestore(&phba->hbalock, flags);
> + spin_unlock_irqrestore(&phba->ct_ev_lock, flags);
> return;
> }
>
> @@ -1195,7 +1195,7 @@ lpfc_issue_ct_rsp_cmp(struct lpfc_hba *phba,
> dd_data = cmdiocbq->context1;
> /* normal completion and timeout crossed paths, already done */
> if (!dd_data) {
> - spin_unlock_irqrestore(&phba->hbalock, flags);
> + spin_unlock_irqrestore(&phba->ct_ev_lock, flags);
> return;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: NET: netpoll, fix potential NULL ptr dereference
Next: [PATCH] exit: fix oops in sync_mm_rss