SLUB: The Unified slab allocator (V3)
in [Kernel]
|
Prev: davinci_emac: Fix use after free in davinci_emac_remove
Next: cgroups: read-write lock CLONE_THREAD forking per threadgroup
From: David Rientjes on 4 Aug 2010 00:40 On Tue, 3 Aug 2010, Christoph Lameter wrote: > The following is a first release of an allocator based on SLAB > and SLUB that integrates the best approaches from both allocators. The > per cpu queuing is like the two prior releases. The NUMA facilities > were much improved vs V2. Shared and alien cache support was added to > track the cache hot state of objects. > This insta-reboots on my netperf benchmarking servers (but works with numa=off), so I'll have to wait until I can hook up a serial before benchmarking this series. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Lameter on 4 Aug 2010 12:20 On Tue, 3 Aug 2010, David Rientjes wrote: > On Tue, 3 Aug 2010, Christoph Lameter wrote: > > > The following is a first release of an allocator based on SLAB > > and SLUB that integrates the best approaches from both allocators. The > > per cpu queuing is like the two prior releases. The NUMA facilities > > were much improved vs V2. Shared and alien cache support was added to > > track the cache hot state of objects. > > > > This insta-reboots on my netperf benchmarking servers (but works with > numa=off), so I'll have to wait until I can hook up a serial before > benchmarking this series. There are potential issues with 1. The size of per cpu reservation on bootup and the new percpu code that allows allocations for per cpu areas during bootup. Sometime I wonder if I should just go back to static allocs for that. 2. The topology information provided by the machine for the cache setup. 3. My code of course. Bootlog would be appreciated. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: David Rientjes on 5 Aug 2010 04:40 On Wed, 4 Aug 2010, Christoph Lameter wrote: > > This insta-reboots on my netperf benchmarking servers (but works with > > numa=off), so I'll have to wait until I can hook up a serial before > > benchmarking this series. > > There are potential issues with > > 1. The size of per cpu reservation on bootup and the new percpu code that > allows allocations for per cpu areas during bootup. Sometime I wonder if I > should just go back to static allocs for that. > > 2. The topology information provided by the machine for the cache setup. > > 3. My code of course. > I bisected this to patch 8 but still don't have a bootlog. I'm assuming in the meantime that something is kmallocing DMA memory on this machine prior to kmem_cache_init_late() and get_slab() is returning a NULL pointer. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Lameter on 5 Aug 2010 13:40
On Thu, 5 Aug 2010, David Rientjes wrote: > I bisected this to patch 8 but still don't have a bootlog. I'm assuming > in the meantime that something is kmallocing DMA memory on this machine > prior to kmem_cache_init_late() and get_slab() is returning a NULL > pointer. There is a kernel option "earlyprintk=..." that allows you to see early boot messages. If this indeed is a problem with the DMA caches then try the following patch: Subject: slub: Move dma cache initialization up Do dma kmalloc initialization in kmem_cache_init and not in kmem_cache_init_late() Signed-off-by: Christoph Lameter <cl(a)linux.com> --- mm/slub.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) Index: linux-2.6/mm/slub.c =================================================================== --- linux-2.6.orig/mm/slub.c 2010-08-05 12:24:21.000000000 -0500 +++ linux-2.6/mm/slub.c 2010-08-05 12:28:58.000000000 -0500 @@ -3866,13 +3866,8 @@ void __init kmem_cache_init(void) #ifdef CONFIG_SMP register_cpu_notifier(&slab_notifier); #endif -} -void __init kmem_cache_init_late(void) -{ #ifdef CONFIG_ZONE_DMA - int i; - /* Create the dma kmalloc array and make it operational */ for (i = 0; i < SLUB_PAGE_SHIFT; i++) { struct kmem_cache *s = kmalloc_caches[i]; @@ -3891,6 +3886,10 @@ void __init kmem_cache_init_late(void) #endif } +void __init kmem_cache_init_late(void) +{ +} + /* * Find a mergeable slab cache */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |