Slabinfo: Fix display format
in [Kernel]
|
Prev: MIPS: return after handling coprocessor 2 exception
Next: [PATCH] Add TAINT_HARDWARE_UNSUPPORTED flag
From: Christoph Lameter on 17 Jun 2010 09:50 On Thu, 17 Jun 2010, wzt.wzt(a)gmail.com wrote: > @@ -4271,7 +4271,7 @@ static int s_show(struct seq_file *m, void *p) > if (error) > printk(KERN_ERR "slab: cache %s error: %s\n", name, error); > > - seq_printf(m, "%-17s %6lu %6lu %6u %4u %4d", > + seq_printf(m, "%-27s %6lu %6lu %6u %4u %4d", > name, active_objs, num_objs, cachep->buffer_size, > cachep->num, (1 << cachep->gfporder)); > seq_printf(m, " : tunables %4u %4u %4u", This one may break user space tools that have assumptions about the length of the field. Or do tools not make that assumption? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: wzt wzt on 17 Jun 2010 10:20 On Thu, Jun 17, 2010 at 9:45 PM, Christoph Lameter <cl(a)linux-foundation.org> wrote: > On Thu, 17 Jun 2010, wzt.wzt(a)gmail.com wrote: > This one may break user space tools that have assumptions about the length > of the field. Or do tools not make that assumption? > User space tools usually use sscanf() to extract this field like: sscanf(buff, "%s %d", name, &num); If %-27s can break some user space tools that have assumptions about the length of the field, the orig %-17s can also break it. The longest name inotify_event_private_data is 26 bytes in 2.6.34-rc2, the tools still can't extract it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pekka Enberg on 18 Jun 2010 02:10
On 6/17/10 5:10 PM, wzt wzt wrote: > On Thu, Jun 17, 2010 at 9:45 PM, Christoph Lameter > <cl(a)linux-foundation.org> wrote: >> On Thu, 17 Jun 2010, wzt.wzt(a)gmail.com wrote: > >> This one may break user space tools that have assumptions about the length >> of the field. Or do tools not make that assumption? > > User space tools usually use sscanf() to extract this field like: > sscanf(buff, "%s %d", name,&num); > If %-27s can break some user space tools that have assumptions about > the length of the field, the orig %-17s can also break it. > The longest name inotify_event_private_data is 26 bytes in 2.6.34-rc2, > the tools still can't extract it. NAK. It's an ABI so the risks of this format cleanup outweight the benefits. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |