Small typo in kernel [current source from git] .config option
in [Kernel]
|
From: Nir Tzachar on 29 Jul 2010 01:10 Hello. On Wed, Jul 28, 2010 at 9:55 PM, Sam Ravnborg <sam(a)ravnborg.org> wrote: > On Wed, Jul 28, 2010 at 05:41:47PM +0200, Michal Marek wrote: >> (adding Nir, who wrote nconfig, to CC). >> >> On 28.7.2010 14:17, trapDoor wrote: >> > On Wed, Jul 28, 2010 at 12:02 PM, Michal Marek <mmarek(a)suse.cz> wrote: >> >> respectively). Unfortunatelly, there doesn't seem to be a way to >> >> highlight single letters in an ncurses menu, hence the strange >> >> cApitalization :(. >> > >> > I wonder how is this resolved in other console applications such as >> > Midnight Commander. Does it have its own implementation for >> > highlighting characters (it uses coloured mnemonics e.g. in menus) or >> > it's based on some common Linux/Unix library which perhaps could be >> > used for the nconfig as well? >> >> The problem is that nconfig uses the higher-level ncurses libraries >> libmenu and libpanel, which make some things easier, but aren't as >> flexible as using ncurses directly. Patches are welcome of course :-). The problem does arise from the use of libmenue, which gives you no control over the rendering of menue items. You can not specify any attributes for specific menu item's letters. > The capitilazing is the main reason why I have > not recommended nconfig to be default. > > And I doubt the shortcut letters are used that often. > One idea could be to drop the shortcut for the individual menus. I almost never use them and removing them will have the benefit of cleaning the code. A different approach may be to reimplement libmenu's logic (recreating the old lxdialog code), but avoiding this was part of the reason for writing nconfig.... In any way, I am happy people are starting to use nconfig. Cheers. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: trapDoor on 29 Jul 2010 02:30 Hello, On Thu, Jul 29, 2010 at 6:04 AM, Nir Tzachar <nir.tzachar(a)gmail.com> wrote: > Hello. > > On Wed, Jul 28, 2010 at 9:55 PM, Sam Ravnborg <sam(a)ravnborg.org> wrote: >> On Wed, Jul 28, 2010 at 05:41:47PM +0200, Michal Marek wrote: >>> (adding Nir, who wrote nconfig, to CC). >>> >>> On 28.7.2010 14:17, trapDoor wrote: >>> > On Wed, Jul 28, 2010 at 12:02 PM, Michal Marek <mmarek(a)suse.cz> wrote: >>> >> respectively). Unfortunatelly, there doesn't seem to be a way to >>> >> highlight single letters in an ncurses menu, hence the strange >>> >> cApitalization :(. >>> > >>> > I wonder how is this resolved in other console applications such as >>> > Midnight Commander. Does it have its own implementation for >>> > highlighting characters (it uses coloured mnemonics e.g. in menus) or >>> > it's based on some common Linux/Unix library which perhaps could be >>> > used for the nconfig as well? >>> >>> The problem is that nconfig uses the higher-level ncurses libraries >>> libmenu and libpanel, which make some things easier, but aren't as >>> flexible as using ncurses directly. Patches are welcome of course :-). > > The problem does arise from the use of libmenue, which gives you no > control over the rendering of menue items. You can not specify any > attributes for specific menu item's letters. > >> The capitilazing is the main reason why I have >> not recommended nconfig to be default. >> >> And I doubt the shortcut letters are used that often. >> One idea could be to drop the shortcut for the individual menus. > > I almost never use them and removing them will have the benefit of > cleaning the code. > Neither do I. And I don't know anyone who would find them very useful. Anyway, if you compile kernel regularly, especially from git, you usually keep the same .config from previous compilations, and just run make oldconfig rather than any of the graphical tools. Unless you want to do some major changes. But even then I don't think many people would care about key shortcuts. Only if they were going to be kept in nconfig I'd say that fixing the capitalisation somehow would be a good thing to do. But if you are going to remove them and thus make the fix possible and the code cleaner - that suits me. I will still prefer the simple and clean nconfig's interface over menuconfig with mnemonics. > A different approach may be to reimplement libmenu's logic (recreating > the old lxdialog code), but avoiding this was part of the reason for > writing nconfig.... > > In any way, I am happy people are starting to use nconfig. > Cheers. > -- Thanks, trapDoor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michal Marek on 29 Jul 2010 04:10 On 29.7.2010 08:20, trapDoor wrote: > On Thu, Jul 29, 2010 at 6:04 AM, Nir Tzachar <nir.tzachar(a)gmail.com> wrote: >> On Wed, Jul 28, 2010 at 9:55 PM, Sam Ravnborg <sam(a)ravnborg.org> wrote: >>> The capitilazing is the main reason why I have >>> not recommended nconfig to be default. >>> >>> And I doubt the shortcut letters are used that often. >>> One idea could be to drop the shortcut for the individual menus. >> >> I almost never use them and removing them will have the benefit of >> cleaning the code. > > Neither do I. And I don't know anyone who would find them very useful. I actually do. Unlike menuconfig, nconfig will jump to a menu item even if it is not currently visible in the screen. Useful if you know the option name but don't want to scroll down and look for it. But I would accept a patch to remove the shortcut if there is no better way of marking the shortcuts than the capital letters. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Nir Tzachar on 29 Jul 2010 06:40 On Thu, Jul 29, 2010 at 11:05 AM, Michal Marek <mmarek(a)suse.cz> wrote: > On 29.7.2010 08:20, trapDoor wrote: >> On Thu, Jul 29, 2010 at 6:04 AM, Nir Tzachar <nir.tzachar(a)gmail.com> wrote: >>> On Wed, Jul 28, 2010 at 9:55 PM, Sam Ravnborg <sam(a)ravnborg.org> wrote: >>>> The capitilazing is the main reason why I have >>>> not recommended nconfig to be default. >>>> >>>> And I doubt the shortcut letters are used that often. >>>> One idea could be to drop the shortcut for the individual menus. >>> >>> I almost never use them and removing them will have the benefit of >>> cleaning the code. >> >> Neither do I. And I don't know anyone who would find them very useful. > > I actually do. Unlike menuconfig, nconfig will jump to a menu item even > if it is not currently visible in the screen. Useful if you know the > option name but don't want to scroll down and look for it. But I would > accept a patch to remove the shortcut if there is no better way of > marking the shortcuts than the capital letters. > > Michal > There is a middle ground here: keep the shortcuts, but give no visual indication (either capitalization or coloring). What do you say? I actually like this, as I dislike the ugly capitalization hack. Cheers. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 29 Jul 2010 10:20 On Thu, 29 Jul 2010 13:33:49 +0300 Nir Tzachar wrote: > On Thu, Jul 29, 2010 at 11:05 AM, Michal Marek <mmarek(a)suse.cz> wrote: > > On 29.7.2010 08:20, trapDoor wrote: > >> On Thu, Jul 29, 2010 at 6:04 AM, Nir Tzachar <nir.tzachar(a)gmail.com> wrote: > >>> On Wed, Jul 28, 2010 at 9:55 PM, Sam Ravnborg <sam(a)ravnborg.org> wrote: > >>>> The capitilazing is the main reason why I have > >>>> not recommended nconfig to be default. > >>>> > >>>> And I doubt the shortcut letters are used that often. > >>>> One idea could be to drop the shortcut for the individual menus. > >>> > >>> I almost never use them and removing them will have the benefit of > >>> cleaning the code. > >> > >> Neither do I. And I don't know anyone who would find them very useful. > > > > I actually do. Unlike menuconfig, nconfig will jump to a menu item even > > if it is not currently visible in the screen. Useful if you know the > > option name but don't want to scroll down and look for it. But I would > > accept a patch to remove the shortcut if there is no better way of > > marking the shortcuts than the capital letters. > > > > Michal > > > > There is a middle ground here: keep the shortcuts, but give no visual > indication (either capitalization or coloring). How do you tell libmenue what the shortcut character is? Is that a different attribute/field/specifier? If so, how about just adding the shortcut key in parentheses [or square brackets] after its word or phrase? E.g.: Hardware Error Device [A] > What do you say? I actually like this, as I dislike the ugly > capitalization hack. It's not pretty and it can be confusing, but I would certainly prefer to have some indicator for the shortcuts. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
First
|
Prev
|
Next
|
Last
Pages: 1 2 3 4 Prev: battery-2.6.35.git Next: ipmi: Fix memleaking for add_smi when duplicating happen |