Staging: Comedi: Drivers: Fix coding style issues in dt2801.c
in [Kernel]
|
Prev: [RFC PATCH 5/5] HSI CHAR: Add HSI char device kernel configuration
Next: Staging: Comedi: Drivers: Fix coding style issues in dt2801.c
From: Joe Perches on 22 Apr 2010 00:10 On Wed, 2010-04-21 at 22:46 -0500, Gustavo Silva wrote: > drivers/staging/comedi/drivers/dt2801.c | 100 ++++++++++++++----------------- > 1 files changed, 44 insertions(+), 56 deletions(-) Hi Gustavo. A couple of trivial comments. > diff --git a/drivers/staging/comedi/drivers/dt2801.c b/drivers/staging/comedi/drivers/dt2801.c > index 3f365ae..c4408d8 100644 > --- a/drivers/staging/comedi/drivers/dt2801.c > +++ b/drivers/staging/comedi/drivers/dt2801.c > @@ -102,58 +102,46 @@ COMEDI_INITCLEANUP(driver_dt2801); > > #if 0 You could just as well remove the #if 0 blocks > @@ -374,8 +362,8 @@ static int dt2801_writecmd(struct comedi_device *dev, int command) > > stat = inb_p(dev->iobase + DT2801_STATUS); > if (stat & DT_S_COMPOSITE_ERROR) { > - printk > - ("dt2801: composite-error in dt2801_writecmd(), ignoring\n"); > + printk(KERN_INFO "dt2801: composite-error in dt2801_writecmd()" > + ", ignoring\n"); It's good to preface with KERN_, but better might be to use #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt and strip the "dt2801: " intro and use pr_<level>("%s(): composite-error, ignoring\n", __func__) It's a bit shorter, always gets the appropriate prefix, and would emit the proper function name if ever refactored. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 22 Apr 2010 00:40
On Thu, 2010-04-22 at 06:13 +0200, Wolfram Sang wrote: > What about dev_* in case there are more than one of those devices? or netdev_<level> > Also, KERN_INFO doesn't look right, KERN_WARN? KERN_WARNING. Maybe kernel.h should add: #define pr_warn pr_warning so there would be symmetry between levels of pr_<level>, dev_<level>, netdev_<level>, and netif_<level> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |