Prev: [PATCH] iio: fix typo in userspace example codes and document
Next: [PATCH]trivial:Fix some comments.
From: Joe Perches on 26 Apr 2010 01:10
On Sun, 2010-04-25 at 09:58 -0400, zr.public(a)gmail.com wrote:
> From: Zachary_r <zr.public(a)gmail.com>
> @@ -123,8 +123,8 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>
> for (driv = comedi_drivers; driv; driv = driv->next) {
> if (!try_module_get(driv->module)) {
> - printk
> - ("comedi: failed to increment module count, skipping\n");
> + printk(KERN_INFO "comedi: failed to increment\
> + module count, skipping\n");

Using line continuations like this is incorrect.
There are many uses like this in your proposed patch.

It adds the initial whitespace on the continued line
to the string constant.

Except for macro definitions, linux doesn't generally
use line continuations.

There's no attempt to keep line numbers consistent
across multiple versions.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] iio: fix typo in userspace example codes and document
Next: [PATCH]trivial:Fix some comments.