From: Simon Horman on
On Tue, Jul 06, 2010 at 12:02:25AM +0200, Joe Eloff wrote:
> >From eba804d73097793329e857bebb31bd1de39cad5c Mon Sep 17 00:00:00 2001
> From: Joe Eloff <kagen101(a)gmail.com>
> Date: Mon, 5 Jul 2010 23:53:36 +0200
> Subject: [PATCH 2/2] Staging: dt3155: fix coding style issues in
> dt3155_drv.c
>
> This is a patch to the dt3155_drv.c file that fixes up last errors found
> by the checkpatch.pl tool.
> Signed-off-by: Joe Eloff <kagen101(a)gmail.com>

This looks entirely reasonable to me.

Reviewed-by: Simon Horman <horms(a)verge.net.au>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Joe Eloff on
On Tue, 2010-07-06 at 12:25 -0500, Aldo Cedillo wrote:
> > diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
> > index 66db878..f6edd66 100644
> > --- a/drivers/staging/dt3155/dt3155_drv.c
> > +++ b/drivers/staging/dt3155/dt3155_drv.c
> > @@ -308,33 +308,42 @@ static void dt3155_isr(int irq, void *dev_id, struct pt_regs *regs)
> > #endif
> > if (fb->nbuffers > 2) {
> > if (!are_empty_buffers(minor)) {
> > - /* The number of active + locked buffers is
> > - * at most 2, and since there are none empty, there
> > - * must be at least nbuffers-2 ready buffers.
> > - * This is where we 'drop frames', oldest first. */
> > + /* The number of active +
> > + * locked buffers is at most 2,
> > + * and since there are none empty,
> > + * there must be at least nbuffers-2
> > + * ready buffers.
> > + * This is where we 'drop frames',
> > + * oldest first. */
> > push_empty(pop_ready(minor), minor);
> > }
> >
>
> In the CodingStyle in the kernel you can read:
>
> The preferred style for long (multi-line) comments is:
>
> /*
> * This is the preferred style for multi-line
> * comments in the Linux kernel source code.
> * Please use it consistently.
> *
> * Description: A column of asterisks on the left side,
> * with beginning and ending almost-blank lines.
> */
>
> Again I ask about the coding style because I have seen in many parts of the
> kernel I've seen discrepancies with what is said in the CodingStyle file. So
> I want to get it clear maybe I can help to clean those things.
>
> Thanks,
> Aldo Brett

I presumed all issues would be incorporated into checkpatch.pl. I guess
it isn't.
I think the safest be here then would be to fix the script as to then
have a single point of failure rather than interpretation and reference
documentation in conjunction to the script.

Regards,

Joe



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Simon Horman on
On Tue, Jul 06, 2010 at 12:25:35PM -0500, Aldo Cedillo wrote:
> > diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
> > index 66db878..f6edd66 100644
> > --- a/drivers/staging/dt3155/dt3155_drv.c
> > +++ b/drivers/staging/dt3155/dt3155_drv.c
> > @@ -308,33 +308,42 @@ static void dt3155_isr(int irq, void *dev_id, struct pt_regs *regs)
> >  #endif
> >                        if (fb->nbuffers > 2) {
> >                                if (!are_empty_buffers(minor)) {
> > -                                       /* The number of active + locked buffers is
> > -                                        * at most 2, and since there are none empty, there
> > -                                        * must be at least nbuffers-2 ready buffers.
> > -                                        * This is where we 'drop frames', oldest first. */
> > +                                       /* The number of active +
> > +                                        * locked buffers is at most 2,
> > +                                        * and since there are none empty,
> > +                                        * there must be at least nbuffers-2
> > +                                        * ready buffers.
> > +                                        * This is where we 'drop frames',
> > +                                        * oldest first. */
> >                                        push_empty(pop_ready(minor),  minor);
> >                                }
> >
>
> In the CodingStyle in the kernel you can read:
>
> The preferred style for long (multi-line) comments is:
>
> /*
> * This is the preferred style for multi-line
> * comments in the Linux kernel source code.
> * Please use it consistently.
> *
> * Description: A column of asterisks on the left side,
> * with beginning and ending almost-blank lines.
> */
>
> Again I ask about the coding style because I have seen in many parts of the
> kernel I've seen discrepancies with what is said in the CodingStyle file. So
> I want to get it clear maybe I can help to clean those things.

I believe that you will find both of the following styles in abundance
and that both are acceptable.

/*
* This
* is a multi-line comment
*/

And

/* This
* is a also multi-line comment
*/

Though one may be more acceptable to a given maintainer than the other.
Other variants may also be common and acceptable to some maintainers,
which I suspect is why checkpatch.pl is lenient.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on
On Tue, Jul 06, 2010 at 12:02:25AM +0200, Joe Eloff wrote:
> >From eba804d73097793329e857bebb31bd1de39cad5c Mon Sep 17 00:00:00 2001
> From: Joe Eloff <kagen101(a)gmail.com>
> Date: Mon, 5 Jul 2010 23:53:36 +0200
> Subject: [PATCH 2/2] Staging: dt3155: fix coding style issues in
> dt3155_drv.c
>
> This is a patch to the dt3155_drv.c file that fixes up last errors found
> by the checkpatch.pl tool.
> Signed-off-by: Joe Eloff <kagen101(a)gmail.com>
> ---
> drivers/staging/dt3155/dt3155_drv.c | 33
> ++++++++++++++++++---------------

The patch is line-wrapped and can't be applied :(

care to redo it?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Joe Eloff on
On Thu, 2010-07-08 at 13:00 -0700, Greg KH wrote:
> On Tue, Jul 06, 2010 at 06:53:18PM +0200, Joe Eloff wrote:
> > I just realised how the commit chaining works after messing it up so I have already
> > uploaded a 1/2 and 2/2 and now it made another 2/2 for this patch which is different.
> >
> > I have realised how it works now and wont mess it up again and have no idea how to reverse chain the
> > 3 patches.
> >
> > This now fixes up all checkpatch.pl issues bar 1.
>
> This doesn't apply either :(
>
> care to redo all of these against the latest linux-next?
>
> thanks,
>
> greg k-h

Will redo all against latest tree :(.

Did patches over 3 days, is that why it did not take?

Will get up to date and apply the patches again and send.

Regards,

Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/