Prev: [tip:perf/core] perf probe: Support "string" type
Next: [PATCH 2/3] ASoC: DaVinci: Added selection of clk input pin for McBSP
From: Jiri Slaby on 6 Jul 2010 05:00
On 07/06/2010 12:02 AM, Joe Eloff wrote:
> --- a/drivers/staging/dt3155/dt3155_drv.c
> +++ b/drivers/staging/dt3155/dt3155_drv.c
> @@ -78,7 +78,7 @@ extern void printques(int);
> MODULE_LICENSE("GPL");
>
> /* Error variable. Zero means no error. */
> -int dt3155_errno = 0;
> +int dt3155_errno ;

Isn't this a checkpatch error :)?

--
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Aldo Cedillo on 6 Jul 2010 13:40
> diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
> index 66db878..f6edd66 100644
> --- a/drivers/staging/dt3155/dt3155_drv.c
> +++ b/drivers/staging/dt3155/dt3155_drv.c
> @@ -308,33 +308,42 @@ static void dt3155_isr(int irq, void *dev_id, struct pt_regs *regs)
> �#endif
> � � � � � � � � � � � �if (fb->nbuffers > 2) {
> � � � � � � � � � � � � � � � �if (!are_empty_buffers(minor)) {
> - � � � � � � � � � � � � � � � � � � � /* The number of active + locked buffers is
> - � � � � � � � � � � � � � � � � � � � �* at most 2, and since there are none empty, there
> - � � � � � � � � � � � � � � � � � � � �* must be at least nbuffers-2 ready buffers.
> - � � � � � � � � � � � � � � � � � � � �* This is where we 'drop frames', oldest first. */
> + � � � � � � � � � � � � � � � � � � � /* The number of active +
> + � � � � � � � � � � � � � � � � � � � �* locked buffers is at most 2,
> + � � � � � � � � � � � � � � � � � � � �* and since there are none empty,
> + � � � � � � � � � � � � � � � � � � � �* there must be at least nbuffers-2
> + � � � � � � � � � � � � � � � � � � � �* ready buffers.
> + � � � � � � � � � � � � � � � � � � � �* This is where we 'drop frames',
> + � � � � � � � � � � � � � � � � � � � �* oldest first. */
> � � � � � � � � � � � � � � � � � � � �push_empty(pop_ready(minor), �minor);
> � � � � � � � � � � � � � � � �}
>

In the CodingStyle in the kernel you can read:

The preferred style for long (multi-line) comments is:

/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines.
*/

Again I ask about the coding style because I have seen in many parts of the
kernel I've seen discrepancies with what is said in the CodingStyle file. So
I want to get it clear maybe I can help to clean those things.

Thanks,
Aldo Brett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Aldo Cedillo on 6 Jul 2010 17:30
>
> I presumed all issues would be incorporated into checkpatch.pl. I guess
> it isn't.
> I think the safest be here then would be to fix the script as to then
> have a single point of failure rather than interpretation and reference
> documentation in conjunction to the script.
>
> Regards,
>
> Joe

I think it's a good idea, I don't know thoroughly this script but I think
stuff like this one should be included in the script.
Regards,
Aldo Brett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Aldo Cedillo on 8 Jul 2010 12:40
>
> I believe that you will find both of the following styles in abundance
> and that both are acceptable.
>
> � /*
> � �* This
> � �* is a multi-line comment
> � �*/
>
> And
>
> � /* This
> � �* is a also multi-line comment
> � �*/
>
> Though one may be more acceptable to a given maintainer than the other.
> Other variants may also be common and acceptable to some maintainers,
> which I suspect is why checkpatch.pl is lenient.

:S , so I believe both are correct... as you stated this doesn't help
to make a single
tool to check. Well thanks for the comment.

Aldo Brett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [tip:perf/core] perf probe: Support "string" type
Next: [PATCH 2/3] ASoC: DaVinci: Added selection of clk input pin for McBSP