Prev: [PATCH 2/3] arm: mm: do not set missing flags on ScorpionMP
Next: [PATCH 3/3] arm: macros for wfe, sev instructions
From: Joe Perches on 23 Jul 2010 15:00
On Fri, 2010-07-23 at 11:45 -0700, H Hartley Sweeten wrote:
> The symbols dt3155_dev_open, unique_tag, and allocatorAddr are only used in
> the file dt3155_drv.c and should be static.
> diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
> index 9e7b880..49924d0 100644
> --- a/drivers/staging/dt3155/dt3155_drv.c
> +++ b/drivers/staging/dt3155/dt3155_drv.c
> @@ -118,14 +118,14 @@ static void __iomem *dt3155_lbase[MAXBOARDS] = { NULL
[]
> -u32 dt3155_dev_open[MAXBOARDS] = {0
> +static u32 dt3155_dev_open[MAXBOARDS] = {0
[]
> -u32 unique_tag = 0;;
> +static u32 unique_tag = 0;;

Statics don't need initialization and could you fix
the style issues ("{0", ";;") at the same time please?

static u32 dt3155_dev_open[MAXBOARDS];
static u32 unique_tag;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 26 Jul 2010 18:50
On Fri, Jul 23, 2010 at 01:03:34PM -0700, H Hartley Sweeten wrote:
> The symbols dt3155_dev_open, unique_tag, and allocatorAddr are only used in
> the file dt3155_drv.c and should be static. Also, as pointed out by Joe Perches,
> static variables do not need initialization so remove them. While here, also
> move the definition for allocatorAddr so that all the variables are declared at
> one place in the code.

This doesn't apply after applying your previous patch to this file :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: H Hartley Sweeten on 26 Jul 2010 19:20
On Monday, July 26, 2010 3:35 PM, Greg KH wrote:
> On Fri, Jul 23, 2010 at 01:03:34PM -0700, H Hartley Sweeten wrote:
>> The symbols dt3155_dev_open, unique_tag, and allocatorAddr are only used in
>> the file dt3155_drv.c and should be static. Also, as pointed out by Joe Perches,
>> static variables do not need initialization so remove them. While here, also
>> move the definition for allocatorAddr so that all the variables are declared at
>> one place in the code.
>
> This doesn't apply after applying your previous patch to this file :(

Oops.. I'll fix it up and repost.

Regards,
Hartley--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 2/3] arm: mm: do not set missing flags on ScorpionMP
Next: [PATCH 3/3] arm: macros for wfe, sev instructions