Staging: quatech_usb2: Convert eos semaphore to mutex
in [Kernel]
|
Prev: [PATCH] Staging: quatech_usb2: Convert eos semaphore to mutex
Next: [PATCH v2] mm: Consider the entire user address space during node migration
From: Oliver Neukum on 15 May 2010 18:00 Am Samstag, 15. Mai 2010 23:40:02 schrieb Alessio Igor Bogani: > The eos semaphore is used as a mutex so replace it with a real mutex. Documentation/mutex-design.txt states that a mutex must not be used from within an interrupt handler. Is this outdated? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alessio Igor Bogani on 15 May 2010 18:10 Hi Oliver, 2010/5/15 Oliver Neukum <oliver(a)neukum.org>: > Am Samstag, 15. Mai 2010 23:40:02 schrieb Alessio Igor Bogani: >> The eos semaphore is used as a mutex so replace it with a real mutex. > > Documentation/mutex-design.txt states that a mutex must not be used > from within an interrupt handler. Is this outdated? You are right. Simply I didn't see irqreturn_t return type in function prototype. Sorry for my mistake. Ciao, Alessio -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arjan van de Ven on 16 May 2010 16:50
On Sun, 16 May 2010 00:08:30 +0200 Alessio Igor Bogani <abogani(a)texware.it> wrote: > Hi Oliver, > > 2010/5/15 Oliver Neukum <oliver(a)neukum.org>: > > Am Samstag, 15. Mai 2010 23:40:02 schrieb Alessio Igor Bogani: > >> The eos semaphore is used as a mutex so replace it with a real > >> mutex. > > > > Documentation/mutex-design.txt states that a mutex must not be used > > from within an interrupt handler. Is this outdated? > > You are right. Simply I didn't see irqreturn_t return type in function > prototype. > > Sorry for my mistake. > you might want to convert it to a completion.... that sounds more the usage model that the driver here is doing -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |