Prev: trivial: fix a typo in a filename
Next: [PATCH 3/9] v4 Add section count to memory_block
From: Arnd Bergmann on 3 Aug 2010 09:30
On Saturday 31 July 2010, Edgardo Hames wrote:
>
> -typedef struct p80211ioctl_req {
> +struct p80211ioctl_req {
> char name[WLAN_DEVNAMELEN_MAX];
> caddr_t data;
> u32 magic;
> u16 len;
> u32 result;
> -} __attribute__ ((packed)) p80211ioctl_req_t;
> +} __attribute__ ((packed));

BTW, this data structure is broken and needs fixing.
Putting a pointer in there means that it's incompatible
between 32 and 64 bit user space, among other problems.

The TODO list for this driver already contains "move to
use the in-kernel wireless stack", which should consequently
imply getting rid of this p80211knetdev_do_ioctl function, but
it may be useful to list that as a separate item.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: trivial: fix a typo in a filename
Next: [PATCH 3/9] v4 Add section count to memory_block