Prev: reiserfs locking
Next: [PATCH] Staging: dream: smd: smd_qmi: fix code style issues
From: Thomas Gleixner on 16 Apr 2010 16:00
Steven,

On Fri, 16 Apr 2010, Steven Rostedt wrote:

> On Thu, 2010-04-15 at 21:01 -0700, Chase Douglas wrote:
>
> > > 2) tracing off can be done via filters on functions and/or events
> > > already - so I doubt that the tracing_off_event(level) is necessary
> > > at all.
> > >
> > > schedule_bug() definitely deserves a separate trace_schedule_bug()
> > > event which can be used to stop the tracer by already existing
> > > functionality.
> >
> > Steven said he would be fine with a separate TRACE_EVENT_<blah> macro
> > for the schedule bug if needed, but I'm not sure we need to go that
> > far. If it's configurable through debugfs at run time then it serves
> > my purpose. Unless you feel we should have finer grained control
> > specifically for scheduling while atomic bugs, I'll just leave it as
> > TRACE_EVENT_WARN.
>
> I actually like Thomas's idea better. I need to add the "stop trace on
> event" functionality, and we can insert trace events for bugs, and not

I just assumed that it would work for events already. The stop trace on
function filter works perfect and is a very conveniant tool.

> have this whole "stop tracing here" functions. Instead we could just add
> tracepoints and have a way to pick and choose where to stop tracing.
>
> add a:
>
> include/trace/events/errors.h
>
> #define TRACE_SYSTEM errors
>
> TRACE_EVENT(sched_bug, ....)
>
> etc,
>
>
> When I get back home, I'll add this functionality to stop tracing on
> events. Perhaps I'll even add "TRACE_SUB_SYSTEM" so in the events
> directory, we can have sub layers:
>
> events/errors/BUG/...
> events/errors/WARNING/...

I like that idea. That's solving the problem in a very elegant way.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Chase Douglas on 19 Apr 2010 18:40
> 2) tracing off can be done via filters on functions and/or events
> � already - so I doubt that the tracing_off_event(level) is necessary
> � at all.

I just found what you were meaning here, since there's no
documentation yet about the traceon/traceoff filter command. This
would do exactly what we want for helping us fix bugs.

I'll write some info about the command in ftrace.txt and send a patch
for review so no one else is left out of the party :).

-- Chase
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2 3
Prev: reiserfs locking
Next: [PATCH] Staging: dream: smd: smd_qmi: fix code style issues