Subject: [PATCH] arm: fix KConfig warning for mach-mx25
in [Kernel]
|
Prev: [PATCH/RFC 3/4] hwmon: pmbus driver documentation
Next: libata: take advantage of cmwq and remove concurrency limitations
From: Peter Hüwe on 28 Jun 2010 18:10 From: Peter Huewe <peterhuewe(a)gmx.de This patch fixes a KConfig warning: "arch/arm/mach-mx25/Kconfig:18:warning: choice value used outside its choice group" Signed-off-by: Peter Huewe <peterhuewe(a)gmx.de> --- KernelVersion: linux-next-20100628 arch/arm/mach-mx25/Kconfig | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mx25/Kconfig b/arch/arm/mach-mx25/Kconfig index 3a6668e..2f436ed 100644 --- a/arch/arm/mach-mx25/Kconfig +++ b/arch/arm/mach-mx25/Kconfig @@ -15,8 +15,7 @@ choice default MACH_EUKREA_MBIMXSD_BASEBOARD config MACH_EUKREA_MBIMXSD_BASEBOARD - prompt "Eukrea MBIMXSD development board" - bool + bool "Eukrea MBIMXSD development board" help This adds board specific devices that can be found on Eukrea's MBIMXSD evaluation board. -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Uwe Kleine-König on 29 Jun 2010 03:00
Hiho, [added linux-kbuild(a)vger.kernel.org to Cc:] On Tue, Jun 29, 2010 at 12:05:20AM +0200, Peter H�we wrote: > From: Peter Huewe <peterhuewe(a)gmx.de > > This patch fixes a KConfig warning: > "arch/arm/mach-mx25/Kconfig:18:warning: choice value used outside its > choice group" > > Signed-off-by: Peter Huewe <peterhuewe(a)gmx.de> The problem also goes away when renaming one of the two MACH_EUKREA_MBIMXSD_BASEBOARD (the other MACH_EUKREA_MBIMXSD_BASEBOARD is in arch/arm/mach-mx3/Kconfig). AFAIK Eric already sent a patch to fix this. I think this is the real issue, I don't know why the warning goes away with your patch. Nevertheless I like your patch. And note there are two other variables in arch/arm/mach-mx2 that could benefit from the same "fix". (But as I moved this file in my tree I suggest to wait until my changes hit Linus' tree and then fix arch/arm/mach-imx/Kconfig.) Best regards Uwe > --- > KernelVersion: linux-next-20100628 > arch/arm/mach-mx25/Kconfig | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-mx25/Kconfig b/arch/arm/mach-mx25/Kconfig > index 3a6668e..2f436ed 100644 > --- a/arch/arm/mach-mx25/Kconfig > +++ b/arch/arm/mach-mx25/Kconfig > @@ -15,8 +15,7 @@ choice > default MACH_EUKREA_MBIMXSD_BASEBOARD > > config MACH_EUKREA_MBIMXSD_BASEBOARD > - prompt "Eukrea MBIMXSD development board" > - bool > + bool "Eukrea MBIMXSD development board" > help > This adds board specific devices that can be found on Eukrea's > MBIMXSD evaluation board. > -- > 1.7.1 -- Pengutronix e.K. | Uwe Kleine-K�nig | Industrial Linux Solutions | http://www.pengutronix.de/ | Pengutronix e.K. | Uwe Kleine-K�nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |