From: Avi Kivity on
On 06/12/2010 03:17 PM, K.de Jong wrote:
> From 6b9ac8708d856a425a9aaa598acdea3d89485bde Mon Sep 17 00:00:00 2001
> From: UndiFineD<k.dejong(a)undifined.nl>
> Date: Sat, 12 Jun 2010 00:24:28 +0200
> Subject: [PATCH] These are my first patches to the kernel
> Janitor patches to kvm
> Linus2.6: virt/kvm/
>
>

Most of the patch is just whitespace changes, which don't improve the
code in any way. I much prefer patches that fix bugs or add features.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: K.de Jong on
2010/6/13 Avi Kivity <avi(a)redhat.com>:
> On 06/12/2010 03:17 PM, K.de Jong wrote:
>>
>>  From 6b9ac8708d856a425a9aaa598acdea3d89485bde Mon Sep 17 00:00:00 2001
>> From: UndiFineD<k.dejong(a)undifined.nl>
>> Date: Sat, 12 Jun 2010 00:24:28 +0200
>> Subject: [PATCH] These are my first patches to the kernel
>> Janitor patches to kvm
>> Linus2.6: virt/kvm/
>>
>>
>
> Most of the patch is just whitespace changes, which don't improve the code
> in any way.  I much prefer patches that fix bugs or add features.
>
Ofcourse everyone prefers bug fixes and new features :-)
I simply looked at greg's "submit a patch" video.
And thought, hey I could do this, and help clean up code.
Cleaner code makes it more accessible
and I get to know where everything is located.
So I am going to continue making patches like these
and become more familiar with the whole kernel.

--
Keimpe de Jong
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Wolfram Sang on
> So I am going to continue making patches like these
> and become more familiar with the whole kernel.

Better concentrate on the drivers/staging-directory for that. Such patches are
very welcome there, which may be not so true for the rest of the kernel. You
can probably find a couple of mail-threads stating the pros and cons.

Regards,

Wolfram

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |