Tools perf builtin-trace.c: duplicated includes
in [Kernel]
|
Prev: sysfs-related lockdep warning in __blkdev_get
Next: auxdisplay: section cleanup in cfag12864bfb driver
From: Ingo Molnar on 26 Mar 2010 04:10 * Andrea Gelmini <andrea.gelmini(a)gelma.net> wrote: > tools/perf/builtin-trace.c: util/exec_cmd.h and util/trace-event.h are included more than once. Also, could you please update your patch to fix the subject lines of these auto-generated patches? The subject lines are missing a verb. The correct one would be: Subject: [PATCH 13/16] Tools perf builtin-trace.c: Remove duplicated #includes Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Ingo Molnar on 26 Mar 2010 04:10 * Andrea Gelmini <andrea.gelmini(a)gelma.net> wrote: > tools/perf/builtin-trace.c: util/exec_cmd.h and util/trace-event.h are included more than once. > > Signed-off-by: Andrea Gelmini <andrea.gelmini(a)gelma.net> > --- > tools/perf/builtin-trace.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c > index 407041d..3c699c5 100644 > --- a/tools/perf/builtin-trace.c > +++ b/tools/perf/builtin-trace.c > @@ -59,9 +59,6 @@ static int cleanup_scripting(void) > #include "perf.h" > #include "util/debug.h" > > -#include "util/trace-event.h" > -#include "util/exec_cmd.h" > - > static char const *input_name = "perf.data"; > > static int process_sample_event(event_t *event, struct perf_session *session) Please send a more complete patch that fixes the root cause of the duplication: a few header files are in the middle of the .c file - all inclusions should be at the top of the file. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andrea Gelmini on 26 Mar 2010 09:30
2010/3/26 Ingo Molnar <mingo(a)elte.hu>: > Please send a more complete patch that fixes the root cause of the > duplication: a few header files are in the middle of the .c file - all > inclusions should be at the top of the file. I try to be less intrusive as possibile. Now I reworked the patch, and I'll send it in a while. Thanks a lot for your advices, Andrea -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |