U6715 16550A serial driver support
in [Kernel]
|
Prev: loop: add some basic read-only sysfs attributes
Next: Questions concerning memory mapping in stackable filesystems
From: Philippe Langlais on 5 Aug 2010 05:00 On 08/05/10 09:22, Andrew Morton wrote: > On Thu, 5 Aug 2010 09:14:40 +0200 Philippe Langlais<philippe.langlais(a)stericsson.com> wrote: > > >> >>>> >>>> >>> The patch adds these .set_termios hooks but doesn't actually use them >>> for anything. >>> >>> The changelog doesn't tell us _why_ this was done (it should) and >>> lacking any code to look at it's all a bit mysterious. >>> >>> >>> >> This feature is used in our U6715 8250 platform serial driver, to avoid >> hack in 8250.c set_termios (Alan Cox requirement). >> In this driver the input uart clock frequency depends on baud rate and >> is computed in our set_termios override function. >> The U6715 paltform serial patch has been submitted on linux-arm mailing >> list, >> and is ready to enter Russell King Linux tree. >> > Oh. > > >> More things to do ? >> > Update the changelog to include this rather important information. > Ok is done > As the patches are dependent, treat them as a single series. Russell > can merge them both with Greg's ack or Greg can merge them both with > Russell's ack. > > This patch can be merged before U6715 platform one without problem. Where I post the series in linux-kernel or linux-arm or both mailing lists ? Greg has already taken this patch in its linux-next tree, need to resend to him the patch with new comments ? All U6715 platform patches are already posted in linux-arm mailing list. It's my first contribution and I don't know how to proceed. Thanks Philippe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andrew Morton on 5 Aug 2010 05:10 On Thu, 5 Aug 2010 10:51:31 +0200 Philippe Langlais <philippe.langlais(a)stericsson.com> wrote: > >> More things to do ? > >> > > Update the changelog to include this rather important information. > > > Ok is done > > As the patches are dependent, treat them as a single series. Russell > > can merge them both with Greg's ack or Greg can merge them both with > > Russell's ack. > > > > > This patch can be merged before U6715 platform one without problem. > Where I post the series in linux-kernel or linux-arm or both mailing lists ? Both. > Greg has already taken this patch in its linux-next tree, need to resend > to him the patch with new comments ? Sure, Greg can probably update the changelog. > All U6715 platform patches are already posted in linux-arm mailing list. > It's my first contribution and I don't know how to proceed. I'd suggest that Greg merge both patches. The patch he has at present doesn't do anything useful. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 5 Aug 2010 19:10 On Thu, Aug 05, 2010 at 12:22:06AM -0700, Andrew Morton wrote: > On Thu, 5 Aug 2010 09:14:40 +0200 Philippe Langlais <philippe.langlais(a)stericsson.com> wrote: > > > > > >> > > > The patch adds these .set_termios hooks but doesn't actually use them > > > for anything. > > > > > > The changelog doesn't tell us _why_ this was done (it should) and > > > lacking any code to look at it's all a bit mysterious. > > > > > > > > This feature is used in our U6715 8250 platform serial driver, to avoid > > hack in 8250.c set_termios (Alan Cox requirement). > > In this driver the input uart clock frequency depends on baud rate and > > is computed in our set_termios override function. > > The U6715 paltform serial patch has been submitted on linux-arm mailing > > list, > > and is ready to enter Russell King Linux tree. > > Oh. > > > More things to do ? > > Update the changelog to include this rather important information. > > As the patches are dependent, treat them as a single series. Russell > can merge them both with Greg's ack or Greg can merge them both with > Russell's ack. I've dropped the patch from my tree, so send it through Russell's, with the proper changelog change and: Acked-by: Greg Kroah-Hartman <gregkh(a)suse.de> thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 6 Aug 2010 11:40
On Thu, Aug 05, 2010 at 02:28:55PM +0200, Philippe Langlais wrote: > UART Features extract from STEricsson U6715 data-sheet (arm926 SoC for mobile phone): > * Fully compatible with industry standard 16C550 and 16C450 from various > manufacturers > * RX and TX 64 byte FIFO reduces CPU interrupts > * Full double buffering > * Modem control signals include CTS, RTS, (and DSR, DTR on UART1 only) > * Automatic baud rate selection > * Manual or automatic RTS/CTS smart hardware flow control > * Programmable serial characteristics: > – Baud rate generation (50 to 3.25M baud) > – 5, 6, 7 or 8-bit characters > – Even, odd or no-parity bit generation and detection > – 1, 1.5 or 2 stop bit generation > * Independent control of transmit, receive, line status, data set interrupts and FIFOs > * Full status-reporting capabilities > * Separate DMA signaling for RX and TX > * Timed interrupt to spread receive interrupt on known duration > * DMA time-out interrupt to allow detection of end of reception > * Carkit pulse coding and decoding compliant with USB carkit control interface [40] > > In 16550A auto-configuration, if the fifo size is 64 then it's an U6 16550A port. > Add set_termios hook & export serial8250_do_set_termios, > this feature is used in our U6715 8250 platform serial driver, to avoid > hack in 8250.c set_termios. > In this driver the input uart clock frequency depends on baud rate and > is computed in our set_termios override function. > > Signed-off-by: Philippe Langlais <philippe.langlais(a)stericsson.com> Acked-by: Greg Kroah-Hartman <gregkh(a)suse.de> But isn't this patch needed before the last one in this series in order to keep everything building properly? You might want to move it up to the first one. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |