Prev: [PATCH 1/2] Staging: Fix two warnings that lines run over eighty characters.
Next: [PATCH 2/2] Staging: rt2860: Fixed some warnings generated by checkpatch.pl
From: Parag Warudkar on 6 Mar 2010 21:40
Hi Dave

While building today's git for CONFIG_UML, I got a link error (list_sort
undefined) for xfs.ko.

Currently I am working around it with the below hack. Not sure the right
thing to do would be some where at the arch level for UML or if the below
would be appropriate.

Parag

diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
index b4769e4..2905cda 100644
--- a/fs/xfs/Makefile
+++ b/fs/xfs/Makefile
@@ -94,6 +94,8 @@ xfs-y += xfs_alloc.o \

xfs-$(CONFIG_XFS_TRACE) += xfs_btree_trace.o

+xfs-$(CONFIG_UML) += ../../lib/list_sort.o
+
# Objects in linux/
xfs-y += $(addprefix $(XFS_LINUX)/, \
kmem.o \
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 6 Mar 2010 22:30
Parag Warudkar wrote:
> Hi Dave
>
> While building today's git for CONFIG_UML, I got a link error (list_sort
> undefined) for xfs.ko.
>
> Currently I am working around it with the below hack. Not sure the right
> thing to do would be some where at the arch level for UML or if the below
> would be appropriate.
>
> Parag
>
> diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> index b4769e4..2905cda 100644
> --- a/fs/xfs/Makefile
> +++ b/fs/xfs/Makefile
> @@ -94,6 +94,8 @@ xfs-y += xfs_alloc.o \
>
> xfs-$(CONFIG_XFS_TRACE) += xfs_btree_trace.o
>
> +xfs-$(CONFIG_UML) += ../../lib/list_sort.o
> +
> # Objects in linux/
> xfs-y += $(addprefix $(XFS_LINUX)/, \
> kmem.o \
> --

I posted a patch for xfs to select LIST_SORT (kconfig symbol)
so that the library is built for it (xfs).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Hellwig on 7 Mar 2010 05:10
On Sat, Mar 06, 2010 at 07:25:10PM -0800, Randy Dunlap wrote:
> I posted a patch for xfs to select LIST_SORT (kconfig symbol)
> so that the library is built for it (xfs).

Can you just send it directly to Linus instead of waiting for the
next pull request?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 1/2] Staging: Fix two warnings that lines run over eighty characters.
Next: [PATCH 2/2] Staging: rt2860: Fixed some warnings generated by checkpatch.pl