Prev: [tip:sched/core] sched: task_tick_rt: Remove the obsolete ->signal != NULL check
Next: [PATCH] Documentation/sysctl/vm.txt typo
From: Michał Nazarewicz on 18 Jun 2010 06:40
On Thu, 17 Jun 2010 19:51:01 +0200, Greg KH <greg(a)kroah.com> wrote:

> On Wed, Jun 16, 2010 at 12:08:01PM +0200, Michal Nazarewicz wrote:
>> The Multifunction Compasite Gadget have been cleaned up
>> and refactored so hopefully it looks prettier and works
>> at least as good as before changes.
>>
>> Signed-off-by: Michal Nazarewicz <m.nazarewicz(a)samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com>
>> ---
>> drivers/usb/gadget/Kconfig | 1 +
>> drivers/usb/gadget/multi.c | 262 +++++++++++++++++++++++++-------------------
>> 2 files changed, 148 insertions(+), 115 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
>> index 591ae9f..027f61b 100644
>> --- a/drivers/usb/gadget/Kconfig
>> +++ b/drivers/usb/gadget/Kconfig
>> @@ -863,6 +863,7 @@ config USB_G_NOKIA
>> config USB_G_MULTI
>> tristate "Multifunction Composite Gadget (EXPERIMENTAL)"
>> depends on BLOCK && NET
>> + select USB_G_MULTI_CDC if !USB_G_MULTI_RNDIS
>> help
>> The Multifunction Composite Gadget provides Ethernet (RNDIS
>> and/or CDC Ethernet), mass storage and ACM serial link
>
> Why is this change needed? Did you do something else in this patch that
> requires it?

Without this select it is possible to choose neither RNDIS nor CDC ECM which
in turns builds a module with no configurations.

I've also realised recently that one does not need to specify
bNumConfigurations in usb_device_descriptor since composite counts that for
us so I'll resend this patch with that fixed as well.

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Sergei Shtylyov on 18 Jun 2010 17:30
Hello.

Michal Nazarewicz wrote:

> The Multifunction Compasite Gadget have been cleaned up

Looks like I'll be your spell-checker for a while. Fix "compasite" here as
well please.

> and refactored so hopefully it looks prettier and works
> at least as good as before changes.

> Among other things this also prevents the possibility to
> select no configuration with Kconfig options which would
> result in an unusable driver.

> Signed-off-by: Michal Nazarewicz <m.nazarewicz(a)samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com>

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Michał Nazarewicz on 23 Jun 2010 06:20
> On Mon, Jun 21, 2010 at 01:57:03PM +0200, Michal Nazarewicz wrote:
>> Lets hope seventh time is really a charm. ;)

On Mon, 21 Jun 2010 23:45:34 +0200, Greg KH <greg(a)kroah.com> wrote:
> Your 8th patch was a bit messed up,

That's bizarre...

> but I fixed it up by hand and applied all of them :)

Great, thanks!

> thanks for being persistent.

Thanks for not adding me to kill file. :P

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [tip:sched/core] sched: task_tick_rt: Remove the obsolete ->signal != NULL check
Next: [PATCH] Documentation/sysctl/vm.txt typo