USB: gadget: storage_common: fixed warning building mass storage function
in [Kernel]
|
Prev: [PATCH v2] ftrace: record command lines at more appropriate moment
Next: [PATCH] netfilter : fix typo in Kconfig
From: Andy Shevchenko on 28 Jul 2010 08:30 On Wed, Jul 28, 2010 at 3:13 PM, Michal Nazarewicz <m.nazarewicz(a)samsung.com> wrote: > The "nofua" attribute is used in the File-Storage Gadget but the > functions handling it are defined in storage_common.c (which may be > not a bad thing if anyone will want to port tho "nofua" attribute to > mass storage function) which causes the following warnings: > > drivers/usb/gadget/storage_common.c:718: \ > warning: 'fsg_show_nofua' defined but not used > drivers/usb/gadget/storage_common.c:782: \ > warning: 'fsg_store_nofua' defined but not used > > Adding __maybe_unused fixes this issue. It's a bit odd. Why the warning happens for those two only? There are two more parameters (four methods) to handle 'ro' and 'file' which are done in the same way. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andy Shevchenko on 28 Jul 2010 09:50 2010/7/28 Michał Nazarewicz <m.nazarewicz(a)samsung.com>: >> Why the warning happens for those two only? >> There are two more parameters (four methods) to handle 'ro' and 'file' >> which are done in the same way. > > Those are the only ones that are not used by the mass storage function. Now I got it. I'm just wondering if it somehow useful to append similar parameter to that function. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andy Shevchenko on 9 Aug 2010 07:00
On Thu, Aug 5, 2010 at 1:27 PM, Michal Nazarewicz <m.nazarewicz(a)samsung.com> wrote: > The "nofua" attribute is used in the File-Storage Gadget but the > functions handling it are defined in storage_common.c (which may be > not a bad thing if anyone will want to port tho "nofua" attribute to > mass storage function) which causes the following warnings: > > drivers/usb/gadget/storage_common.c:718: \ > warning: 'fsg_show_nofua' defined but not used > drivers/usb/gadget/storage_common.c:782: \ > warning: 'fsg_store_nofua' defined but not used > > Adding __maybe_unused fixes this issue. > > Signed-off-by: Michal Nazarewicz <m.nazarewicz(a)samsung.com> > Cc: Andy Shevchenko <andy.shevchenko(a)gmail.com> > --- > drivers/usb/gadget/storage_common.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/gadget/storage_common.c b/drivers/usb/gadget/storage_common.c > index 484acfb..3379cc3 100644 > --- a/drivers/usb/gadget/storage_common.c > +++ b/drivers/usb/gadget/storage_common.c > @@ -715,8 +715,8 @@ static ssize_t fsg_show_ro(struct device *dev, struct device_attribute *attr, > : curlun->initially_ro); > } > > -static ssize_t fsg_show_nofua(struct device *dev, struct device_attribute *attr, > - char *buf) > +static ssize_t __maybe_unused > +fsg_show_nofua(struct device *dev, struct device_attribute *attr, char *buf) > { > struct fsg_lun *curlun = fsg_lun_from_dev(dev); > > @@ -779,9 +779,9 @@ static ssize_t fsg_store_ro(struct device *dev, struct device_attribute *attr, > return rc; > } > > -static ssize_t fsg_store_nofua(struct device *dev, > - struct device_attribute *attr, > - const char *buf, size_t count) > +static ssize_t __maybe_unused > +fsg_store_nofua(struct device *dev, struct device_attribute *attr, > + const char *buf, size_t count) > { > struct fsg_lun *curlun = fsg_lun_from_dev(dev); > unsigned long nofua; > -- > 1.7.1 > > Acked-by: Andy Shevchenko <andy.shevchenko(a)gmail.com> -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |