Prev: [PATCH] input: mt: introduce MT event slots
Next: USB: testusb: testusb compatibility with FunctionFS gadget
From: Greg KH on 7 Apr 2010 20:40
On Wed, Apr 07, 2010 at 03:41:34PM +0200, Michal Nazarewicz wrote:
> The testusb application can be used to test various USB gadget
> that implment the source/sink intrerface.
>
> Signed-off-by: Michal Nazarewicz <m.nazarewicz(a)samsung.com>
> Cc: Kyungmin Park <kyungmin.park(a)samsung.com>
> Cc: Marek Szyprowski <m.szyprowski(a)samsung.com>

You should put a:
From: David Brownell <dbrownell(a)users.sourceforge.net>
as the first line of the body of this patch, so it properly shows up as
David's code.

I also would like to get an ack from David that he doesn't mind his code
moving into the kernel here (personally I think it's a good thing to be
here.)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Heikki Krogerus on 8 Apr 2010 02:20
Hi,

If this is going into kernel then..

On Wed, Apr 07, 2010 at 03:41:34PM +0200, ext Michal Nazarewicz wrote:

....

> + if ((c = open ("/proc/bus/usb/devices", O_RDONLY)) < 0) {
> + fputs ("usbfs files are missing\n", stderr);
> + return -1;
> + }

Is this needed?

> +
> + /* collect and list the test devices */
> + if (ftw ("/proc/bus/usb", find_testdev, 3) != 0) {

How about "/dev/bus/usb" instead? Some distributions do not enable
sysfs in their default kernels anymore.

> + fputs ("ftw failed; is usbfs missing?\n", stderr);
> + return -1;
> + }

br,

--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Heikki Krogerus on 8 Apr 2010 02:40
On Thu, Apr 08, 2010 at 08:18:46AM +0200, ext Greg KH wrote:
> On Thu, Apr 08, 2010 at 09:10:00AM +0300, Heikki Krogerus wrote:
> > Hi,
> >
> > If this is going into kernel then..
> >
> > On Wed, Apr 07, 2010 at 03:41:34PM +0200, ext Michal Nazarewicz wrote:
> >
> > ...
> >
> > > + if ((c = open ("/proc/bus/usb/devices", O_RDONLY)) < 0) {
> > > + fputs ("usbfs files are missing\n", stderr);
> > > + return -1;
> > > + }
> >
> > Is this needed?
> >
> > > +
> > > + /* collect and list the test devices */
> > > + if (ftw ("/proc/bus/usb", find_testdev, 3) != 0) {
> >
> > How about "/dev/bus/usb" instead? Some distributions do not enable
> > sysfs in their default kernels anymore.
>
> You mean 'usbfs' not 'sysfs', right?

Yes, usbfs of cource :)

--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] input: mt: introduce MT event slots
Next: USB: testusb: testusb compatibility with FunctionFS gadget