Prev: core: workque: workqueue recursion when unplugging usb WCDMA modem on 2.6.32 kernel
Next: [RFC PATCH 0/5] HSI framework and drivers
From: Greg KH on 23 Apr 2010 11:20
On Fri, Apr 23, 2010 at 12:44:11PM +0200, Eric Lescouet wrote:
> Hi,
>
> The USBIP modules (and some others) have a direct dependency on the following headers:
> - drivers/usb/core/hdc.h (struct usb_hcd and various routines)
> - drivers/usb/core/hub.h (couple of constants)
> Because those headers are not part of include/, it makes it quite difficult
> to compile them as standalone modules (e.g.: against pre-compiled kernel).

Then don't do that :)

> hdc.c and hub.c are relatively self-contained and could be moved to e.g.: include/linux/usb/.
>
> What do you think?

I think the code needs to be cleaned up and merged to the main part of
the kernel tree, then this wouldn't be an issue, right?

Also, please cc: the linux-usb(a)vger.kernel.org list for USB related
things in the future.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 24 Apr 2010 11:20
On Sat, Apr 24, 2010 at 03:24:17AM +0200, Eric Lescouet wrote:
> On 04/23/2010 08:04 PM, Alan Stern wrote:
> > On Fri, 23 Apr 2010, Eric Lescouet wrote:
> >
> >> Well, most of the files include hcd.h (which includes hub.h),
> >> only ~4 of them directly use hub.h.
> >
> > Oh. Okay, that makes life easier. Probably some of the files which
> > include hub.h directly also include hcd.h.
> >
> >> So what's your vote? rename hub.h into ch11.h?
> >
> > Yeah, go ahead. I like the idea of the kernel containing information
> > about Chapter 11. (Although I haven't heard of anyone yet going
> > bankrupt as a result of using Linux...)
> >
> > Alan Stern
> >
>
> It looks like couple of files in drivers/usb/core and usb/host have been
> modified already in latest snapshot (2.6.34-rc5-git5).
> Is it still ok to provide the patches against the mainline (2.6.34-rc5)
> or should I do it against the snapshot (2.6.34-rc5-git5)?

The latest snapshot is best.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: core: workque: workqueue recursion when unplugging usb WCDMA modem on 2.6.32 kernel
Next: [RFC PATCH 0/5] HSI framework and drivers