From: Stefan Lippers-Hollmann on
Hi

On Friday 27 November 2009, Mauro Carvalho Chehab wrote:
> Hi Linus,
>
> Please pull from:
> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git for_linus
>
> For the following drivers and building fixes:
>
> - radio-gemtek-pci: fix double mutex_lock
> - v4l: add more missing linux/sched.h includes
> - soc-camera: properly initialise the device object when reusing
> - soc-camera: sh_mobile_ceu_camera: call pm_runtime_disable
> - em28xx: fix Reddo DVB-C USB TV Box GPIO
> - davinci: remove stray duplicate config pointer
> - SMS_SIANO_MDTV should depend on HAS_DMA
> - cxusb: Fix hang on DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1)
> - sh_mobile_ceu_camera: fix compile warning
> - Fix wrong parameter order in memset
[...]

Please consider cherry picking the following two patches from Hans
Verkuil [1]:
- add the missing s2250-loader.h
- s2250 mutex patch

or revert the patch which broke compiling go7007-usb (imho it would be
better to re-add the 2 externs [2], than throwing away the needed mutex
conversion, but it would be an option)
Commit: fd9a40da1db372833e1af6397d2f6c94ceff3dad
V4L/DVB (12859): go7007: semaphore -> mutex conversion

or mark CONFIG_VIDEO_GO7007_USB_S2250_BOARD as BROKEN, as it fails to
compile since the afforementioned patch was merged on september 19th (this
is a 2.6.31 --> 2.6.32 regression) [2,3].

Regards
Stefan Lippers-Hollmann

[1] http://www.mail-archive.com/linux-media(a)vger.kernel.org/msg11736.html
[2] http://lkml.indiana.edu/hypermail/linux/kernel/0911.1/02303.html
[3] http://lkml.indiana.edu/hypermail/linux/kernel/0909.3/00062.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Hans Verkuil on
On Friday 27 November 2009 22:40:01 Stefan Lippers-Hollmann wrote:
> Hi
>
> On Friday 27 November 2009, Mauro Carvalho Chehab wrote:
> > Hi Linus,
> >
> > Please pull from:
> > ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git for_linus
> >
> > For the following drivers and building fixes:
> >
> > - radio-gemtek-pci: fix double mutex_lock
> > - v4l: add more missing linux/sched.h includes
> > - soc-camera: properly initialise the device object when reusing
> > - soc-camera: sh_mobile_ceu_camera: call pm_runtime_disable
> > - em28xx: fix Reddo DVB-C USB TV Box GPIO
> > - davinci: remove stray duplicate config pointer
> > - SMS_SIANO_MDTV should depend on HAS_DMA
> > - cxusb: Fix hang on DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1)
> > - sh_mobile_ceu_camera: fix compile warning
> > - Fix wrong parameter order in memset
> [...]
>
> Please consider cherry picking the following two patches from Hans
> Verkuil [1]:
> - add the missing s2250-loader.h
> - s2250 mutex patch

Good catch. Mauro, can you please add these two as well for 2.6.32? I'm sure
I marked these two as high-prio patches. This staging driver is actively
being used and developed so this regression should be fixed.

Thanks,

Hans

>
> or revert the patch which broke compiling go7007-usb (imho it would be
> better to re-add the 2 externs [2], than throwing away the needed mutex
> conversion, but it would be an option)
> Commit: fd9a40da1db372833e1af6397d2f6c94ceff3dad
> V4L/DVB (12859): go7007: semaphore -> mutex conversion
>
> or mark CONFIG_VIDEO_GO7007_USB_S2250_BOARD as BROKEN, as it fails to
> compile since the afforementioned patch was merged on september 19th (this
> is a 2.6.31 --> 2.6.32 regression) [2,3].
>
> Regards
> Stefan Lippers-Hollmann
>
> [1] http://www.mail-archive.com/linux-media(a)vger.kernel.org/msg11736.html
> [2] http://lkml.indiana.edu/hypermail/linux/kernel/0911.1/02303.html
> [3] http://lkml.indiana.edu/hypermail/linux/kernel/0909.3/00062.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo(a)vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
Hans Verkuil - video4linux developer - sponsored by TANDBERG
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Mike Isely on
On Sat, 28 Nov 2009, Hans Verkuil wrote:

> On Friday 27 November 2009 22:40:01 Stefan Lippers-Hollmann wrote:
> > Hi
> >
> > On Friday 27 November 2009, Mauro Carvalho Chehab wrote:
> > > Hi Linus,
> > >
> > > Please pull from:
> > > ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git for_linus
> > >
> > > For the following drivers and building fixes:
> > >
> > > - radio-gemtek-pci: fix double mutex_lock
> > > - v4l: add more missing linux/sched.h includes
> > > - soc-camera: properly initialise the device object when reusing
> > > - soc-camera: sh_mobile_ceu_camera: call pm_runtime_disable
> > > - em28xx: fix Reddo DVB-C USB TV Box GPIO
> > > - davinci: remove stray duplicate config pointer
> > > - SMS_SIANO_MDTV should depend on HAS_DMA
> > > - cxusb: Fix hang on DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1)
> > > - sh_mobile_ceu_camera: fix compile warning
> > > - Fix wrong parameter order in memset
> > [...]
> >
> > Please consider cherry picking the following two patches from Hans
> > Verkuil [1]:
> > - add the missing s2250-loader.h
> > - s2250 mutex patch
>
> Good catch. Mauro, can you please add these two as well for 2.6.32? I'm sure
> I marked these two as high-prio patches. This staging driver is actively
> being used and developed so this regression should be fixed.
>

Mauro:

I had also posted up two high priority pvrusb2 patches that should
really be cherry-picked for 2.6.32. You've already pulled them into
v4l/dvb and I did mark them as high priority at the time.

These patches enable use of FX2 microcontroller firmware that is 16KB in
size. Hauppauge is no longer shipping 8KB firmware for HVR-1950 and
HVR-1900 and without these changes then those devices won't work AT ALL
in kernel 2.6.32.

You can find these within the v4l-dvb Mercurial repository here:

Changeset 13495:87c3853fe2b3
Subject: pvrusb2: Support 16KB FX2 firmware
http://linuxtv.org/hg/v4l-dvb/rev/87c3853fe2b3

Changeset 13500:d4c418d4b25c
Subject: pvrusb2: Fix lingering 16KB FX2 Firmware issues
http://linuxtv.org/hg/v4l-dvb/rev/d4c418d4b25c

I do not believe these patches have any ordering dependencies with other
patches, though between the two the second one technically should come
after the first.

Thanks,

-Mike


--

Mike Isely
isely @ isely (dot) net
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Mauro Carvalho Chehab on
Em Sat, 28 Nov 2009 14:33:30 -0600 (CST)
Mike Isely <isely(a)isely.net> escreveu:

> On Sat, 28 Nov 2009, Hans Verkuil wrote:
>
> > On Friday 27 November 2009 22:40:01 Stefan Lippers-Hollmann wrote:
> > > Hi
> > >
> > > On Friday 27 November 2009, Mauro Carvalho Chehab wrote:
> > > > Hi Linus,
> > > >
> > > > Please pull from:
> > > > ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git for_linus
> > > >
> > > > For the following drivers and building fixes:
> > > >
> > > > - radio-gemtek-pci: fix double mutex_lock
> > > > - v4l: add more missing linux/sched.h includes
> > > > - soc-camera: properly initialise the device object when reusing
> > > > - soc-camera: sh_mobile_ceu_camera: call pm_runtime_disable
> > > > - em28xx: fix Reddo DVB-C USB TV Box GPIO
> > > > - davinci: remove stray duplicate config pointer
> > > > - SMS_SIANO_MDTV should depend on HAS_DMA
> > > > - cxusb: Fix hang on DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1)
> > > > - sh_mobile_ceu_camera: fix compile warning
> > > > - Fix wrong parameter order in memset
> > > [...]
> > >
> > > Please consider cherry picking the following two patches from Hans
> > > Verkuil [1]:
> > > - add the missing s2250-loader.h
> > > - s2250 mutex patch
> >
> > Good catch. Mauro, can you please add these two as well for 2.6.32? I'm sure
> > I marked these two as high-prio patches. This staging driver is actively
> > being used and developed so this regression should be fixed.
> >
>
> Mauro:
>
> I had also posted up two high priority pvrusb2 patches that should
> really be cherry-picked for 2.6.32. You've already pulled them into
> v4l/dvb and I did mark them as high priority at the time.
>
> These patches enable use of FX2 microcontroller firmware that is 16KB in
> size. Hauppauge is no longer shipping 8KB firmware for HVR-1950 and
> HVR-1900 and without these changes then those devices won't work AT ALL
> in kernel 2.6.32.
>
> You can find these within the v4l-dvb Mercurial repository here:
>
> Changeset 13495:87c3853fe2b3
> Subject: pvrusb2: Support 16KB FX2 firmware
> http://linuxtv.org/hg/v4l-dvb/rev/87c3853fe2b3
>
> Changeset 13500:d4c418d4b25c
> Subject: pvrusb2: Fix lingering 16KB FX2 Firmware issues
> http://linuxtv.org/hg/v4l-dvb/rev/d4c418d4b25c
>
> I do not believe these patches have any ordering dependencies with other
> patches, though between the two the second one technically should come
> after the first.

There are. Picking just those patches broke compilation.

Also, it seemed too late for adding support for newer boards/firmware when Linus
is about to release a kernel.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Mauro Carvalho Chehab on
Em Sat, 28 Nov 2009 03:57:58 +0100
Hans Verkuil <hverkuil(a)xs4all.nl> escreveu:

> On Friday 27 November 2009 22:40:01 Stefan Lippers-Hollmann wrote:
> > Hi
> >
> > On Friday 27 November 2009, Mauro Carvalho Chehab wrote:
> > > Hi Linus,
> > >
> > > Please pull from:
> > > ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git for_linus
> > >
> > > For the following drivers and building fixes:
> > >
> > > - radio-gemtek-pci: fix double mutex_lock
> > > - v4l: add more missing linux/sched.h includes
> > > - soc-camera: properly initialise the device object when reusing
> > > - soc-camera: sh_mobile_ceu_camera: call pm_runtime_disable
> > > - em28xx: fix Reddo DVB-C USB TV Box GPIO
> > > - davinci: remove stray duplicate config pointer
> > > - SMS_SIANO_MDTV should depend on HAS_DMA
> > > - cxusb: Fix hang on DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1)
> > > - sh_mobile_ceu_camera: fix compile warning
> > > - Fix wrong parameter order in memset
> > [...]
> >
> > Please consider cherry picking the following two patches from Hans
> > Verkuil [1]:
> > - add the missing s2250-loader.h
> > - s2250 mutex patch
>
> Good catch. Mauro, can you please add these two as well for 2.6.32? I'm sure
> I marked these two as high-prio patches. This staging driver is actively
> being used and developed so this regression should be fixed.

There were a merge problem when applying those patches at -git. As this is a
staging driver, I opted to just move all patches to linux-next, as there were
no mention on the patch subject mentioned that they are, in fact, fixes.

I'll see what can we do to solve the s2250 compilation breakage.

As Linus didn't merge from this pull request yet, I'll work on a fix, based
on one of the Stefan suggestions, preferably backporting the patches.

--

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/