VFS: Simplify truncate logic in do_filp_open()
in [Kernel]
|
Prev: [PATCH] VFS: BUG_ON() rehash of an already hashed dentry
Next: [PATCH] isdn: fix a few Kconfig imperfections
From: Al Viro on 22 Feb 2010 16:10 On Mon, Feb 22, 2010 at 03:35:51PM -0500, Valerie Aurora wrote: > The fact that may_open() could truncate a file gave me a lot of > heartburn when working on union mounts, so I was thrilled to see that > truncate handling has been moved out of may_open() in Al's for-next > tree. However, it seems to me that the surrounding elaborate > mnt_want_write() dance is no longer needed? If so, this also > simplifies Ogawa Hirofumi "Fix use-after-free of vfsmount by > mnt_drop_write()" patch. > > Against Al's for-next branch. Lightly tested, please review. Val, anything around do_filp_open() should be on top of #untested. The whole area gets rewritten there. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Valerie Aurora on 23 Feb 2010 14:10
On Mon, Feb 22, 2010 at 09:08:27PM +0000, Al Viro wrote: > On Mon, Feb 22, 2010 at 03:35:51PM -0500, Valerie Aurora wrote: > > The fact that may_open() could truncate a file gave me a lot of > > heartburn when working on union mounts, so I was thrilled to see that > > truncate handling has been moved out of may_open() in Al's for-next > > tree. However, it seems to me that the surrounding elaborate > > mnt_want_write() dance is no longer needed? If so, this also > > simplifies Ogawa Hirofumi "Fix use-after-free of vfsmount by > > mnt_drop_write()" patch. > > > > Against Al's for-next branch. Lightly tested, please review. > > Val, anything around do_filp_open() should be on top of #untested. The > whole area gets rewritten there. Nice! That's a huge improvement. I will happily rebase. Thanks, -VAL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |