Win32 timezone matching
in [PgSql]
|
From: Magnus Hagander on 15 Apr 2010 04:07 On Thu, Apr 15, 2010 at 2:54 AM, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > [ back to this... ] > > Magnus Hagander <magnus(a)hagander.net> writes: >> On Wed, Apr 7, 2010 at 21:06, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: >>> I suppose we had a reason for doing it the first way but I can't see >>> what. "GMT" seems a fairly English-centric way of referring to UTC >>> anyhow; translators might wish to put in "UTC" instead, or some other >>> spelling. Shouldn't we let them? > >> UTC and GMT aren't actually the same thing. > > Tell it to the zic people --- they are identical except for the zone > abbreviation itself, according to the zic database. There might be some > pedantic argument for preferring the name "UTC", but I'm hesitant to > change that behavior just to satisfy pedants. Agreed, I don't think it's worth changing. However, that also goes to the translation of it - let's keep *one* term, that'll make it a lot less confusing. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Magnus Hagander on 15 Apr 2010 04:12 On Thu, Apr 15, 2010 at 3:48 AM, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > Magnus Hagander <magnus(a)hagander.net> writes: >> On Wed, Apr 7, 2010 at 21:01, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: >>> ... lack either the note about defaulting to GMT or the hint. I guess >>> we should add both of those to the failure cases in the Windows version >>> of identify_system_timezone. Should we also change the WARNING errlevel >>> to LOG? I think the latter is more likely to actually get into the log. > >> You are suggesting adding this after the "could not find match" >> message, correct? Not replacing it? Because if we replace it, we loose >> the information of what we failed to match. So basically like >> attached? > > No, I was thinking more like the attached. This changes the Unix code > to separate the info about the fallback timezone into errdetail, and > then makes the Windows messages follow that style. Yeah, that looks good. >> Also, would LOG be *more* likely to be seen than a WARNING? Why would that be? > > Because that's how log levels sort for the postmaster log. This isn't > an interactive warning --- we will never be executing this code in a > regular backend, only in the postmaster. Well, when the dba looks through the log, he'll be looking a lot harder at something that says WARNING. And if somebody is filtering his log so hard that it doesn't even contain WARNING's, frankly, he's ignorant ;) But that's just me, and I've never really agreed with that soring in the first place, so maybe I should just be ignored... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
First
|
Prev
|
Pages: 1 2 3 4 5 Prev: [HACKERS] Missing win32 timezones Next: [HACKERS] pg_filedump strangeness |