Prev: [PATCH] use find_lock_task_mm in memory cgroups oom
Next: [git pull] Please pull powerpc.git next branch
From: Srikar Dronamraju on 15 Jun 2010 02:40
* Christoph Hellwig <hch(a)infradead.org> [2010-06-14 13:39:26]:

> On Mon, Jun 14, 2010 at 01:58:03PM +0530, Srikar Dronamraju wrote:
> > move_W_to_insn.patch
> >
> > From: Srikar Dronamraju <srikar(a)linux.vnet.ibm.com>
> >
> > Move Macro W to asm/insn.h
> >
> > Macro W used to know if the instructions are valid for
> > user-space/kernel space. This macro is used by kprobes and
> > user_bkpt. (i.e user space breakpoint assistance layer.) So moving it
> > to a common header file asm/insn.h.
>
> I don't think W is a good name for a macro in a header file.

Agree, Masami has also given the same comment earlier, I plan to move to
using inat tables instead of this macro.

--
Thanks and Regards
Srikar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] use find_lock_task_mm in memory cgroups oom
Next: [git pull] Please pull powerpc.git next branch