aic7xxx: Remove OS utility wrappers
in [Kernel]
|
Prev: crypto: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
Next: [GIT PULL] s390 patches for 2.6.35-rc5
From: Hannes Reinecke on 19 Jul 2010 02:50 Pekka Enberg wrote: > This patch removes malloc(), free(), and printf() wrappers from the aic7xxx > SCSI driver. I didn't use pr_debug for printf because of some 'clever' uses of > printf don't compile with the pr_debug. I didn't fix the overeager uses of > GFP_ATOMIC either because I wanted to keep this patch as simple as possible. > > Cc: Hannes Reinecke <hare(a)suse.de> > Cc: "James E.J. Bottomley" <James.Bottomley(a)suse.de> > Cc: Jiri Kosina <jkosina(a)suse.cz> > Cc: "Uwe Kleine-König" <u.kleine-koenig(a)pengutronix.de> > Cc: "André Goddard Rosa" <andre.goddard(a)gmail.com> > Cc: <linux-scsi(a)vger.kernel.org> > Signed-off-by: Pekka Enberg <penberg(a)cs.helsinki.fi> Thanks for the work. Long overdue. Acked-by: Hannes Reinecke <hare(a)suse.de> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare(a)suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: James Bottomley on 27 Jul 2010 13:50 On Mon, 2010-07-19 at 08:42 +0200, Hannes Reinecke wrote: > Pekka Enberg wrote: > > This patch removes malloc(), free(), and printf() wrappers from the aic7xxx > > SCSI driver. I didn't use pr_debug for printf because of some 'clever' uses of > > printf don't compile with the pr_debug. I didn't fix the overeager uses of > > GFP_ATOMIC either because I wanted to keep this patch as simple as possible. > > > > Cc: Hannes Reinecke <hare(a)suse.de> > > Cc: "James E.J. Bottomley" <James.Bottomley(a)suse.de> > > Cc: Jiri Kosina <jkosina(a)suse.cz> > > Cc: "Uwe Kleine-König" <u.kleine-koenig(a)pengutronix.de> > > Cc: "André Goddard Rosa" <andre.goddard(a)gmail.com> > > Cc: <linux-scsi(a)vger.kernel.org> > > Signed-off-by: Pekka Enberg <penberg(a)cs.helsinki.fi> > > Thanks for the work. Long overdue. > > Acked-by: Hannes Reinecke <hare(a)suse.de> A good rule of thumb is compile before acking: drivers/scsi/aic7xxx/aic7770.c: In function 'aic7770_config': drivers/scsi/aic7xxx/aic7770.c:224: error: implicit declaration of function 'free' drivers/scsi/aic7xxx/aic7770.c:224: error: 'M_DEVBUF' undeclared (first use in this function) drivers/scsi/aic7xxx/aic7770.c:224: error: (Each undeclared identifier is reported only once drivers/scsi/aic7xxx/aic7770.c:224: error: for each function it appears in.) make[3]: *** [drivers/scsi/aic7xxx/aic7770.o] Error 1 It looks like a lone missed conversion, so I fixed it up. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pekka Enberg on 27 Jul 2010 14:00
James Bottomley wrote: > On Mon, 2010-07-19 at 08:42 +0200, Hannes Reinecke wrote: >> Pekka Enberg wrote: >>> This patch removes malloc(), free(), and printf() wrappers from the aic7xxx >>> SCSI driver. I didn't use pr_debug for printf because of some 'clever' uses of >>> printf don't compile with the pr_debug. I didn't fix the overeager uses of >>> GFP_ATOMIC either because I wanted to keep this patch as simple as possible. >>> >>> Cc: Hannes Reinecke <hare(a)suse.de> >>> Cc: "James E.J. Bottomley" <James.Bottomley(a)suse.de> >>> Cc: Jiri Kosina <jkosina(a)suse.cz> >>> Cc: "Uwe Kleine-König" <u.kleine-koenig(a)pengutronix.de> >>> Cc: "André Goddard Rosa" <andre.goddard(a)gmail.com> >>> Cc: <linux-scsi(a)vger.kernel.org> >>> Signed-off-by: Pekka Enberg <penberg(a)cs.helsinki.fi> >> Thanks for the work. Long overdue. >> >> Acked-by: Hannes Reinecke <hare(a)suse.de> > > A good rule of thumb is compile before acking: > > drivers/scsi/aic7xxx/aic7770.c: In function 'aic7770_config': > drivers/scsi/aic7xxx/aic7770.c:224: error: implicit declaration of function 'free' > drivers/scsi/aic7xxx/aic7770.c:224: error: 'M_DEVBUF' undeclared (first use in this function) > drivers/scsi/aic7xxx/aic7770.c:224: error: (Each undeclared identifier is reported only once > drivers/scsi/aic7xxx/aic7770.c:224: error: for each function it appears in.) > make[3]: *** [drivers/scsi/aic7xxx/aic7770.o] Error 1 > > It looks like a lone missed conversion, so I fixed it up. Sorry about that, I thought I tested all the configurations. Thanks for fixing it up! Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |