alsa: ASoC: JZ4740: Add qi_lb60 board driver
in [Kernel]
|
Prev: serial: bfin_5xx: IRDA is not affected by anomaly 05000230
Next: arch/tile: infrastructure and configuration-related files.
From: Mark Brown on 3 Jun 2010 14:00 On Wed, Jun 02, 2010 at 09:15:32PM +0200, Lars-Peter Clausen wrote: > + ret = gpio_request(QI_LB60_SND_GPIO, "SND"); > + if (ret) { > + pr_err("qi_lb60 snd: Failed to request SND GPIO(%d): %d\n", > + QI_LB60_SND_GPIO, ret); > + goto err_device_put; > + } > + > + ret = gpio_request(QI_LB60_AMP_GPIO, "AMP"); > + if (ret) { > + pr_err("qi_lb60 snd: Failed to request AMP GPIO(%d): %d\n", > + QI_LB60_AMP_GPIO, ret); > + goto err_gpio_free_snd; > + } > + > + gpio_direction_output(JZ_GPIO_PORTB(29), 0); > + gpio_direction_output(JZ_GPIO_PORTD(4), 0); You're referring to the GPIOs by multiple different names - it'd be more robust to pick one way of naming them and use it consistently (probably the #define). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Liam Girdwood on 22 Jun 2010 06:10
On Sat, 2010-06-19 at 16:51 +0200, 1276924111-11158-27-git-send-email-lars(a)metafoo.de wrote: > From: Lars-Peter Clausen <lars(a)metafoo.de> > > This patch adds ASoC support for the qi_lb60 board. > > Signed-off-by: Lars-Peter Clausen <lars(a)metafoo.de> > Cc: Mark Brown <broonie(a)opensource.wolfsonmicro.com> > Cc: Liam Girdwood <lrg(a)slimlogic.co.uk> > Cc: alsa-devel(a)alsa-project.org Acked-by: Liam Girdwood <lrg(a)slimlogic.co.uk> -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |