Prev: [PATCH] mm: provide init_mm mm_context initializer
Next: ath: Failed to stop TX DMA in 100 msec after killing last frame
From: Ralf Baechle on 26 May 2010 12:40
On Wed, May 26, 2010 at 05:54:55PM +0200, Julia Lawall wrote:

> From: Julia Lawall <julia(a)diku.dk>
>
> Add a read_unlock missing on the error path. Other ways of reaching
> out_unlock have tasklist_lock unlocked.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression E1;
> @@
>
> * read_lock(E1,...);
> <+... when != E1
> if (...) {
> ... when != E1
> * return ...;
> }
> ...+>
> * read_unlock(E1,...);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia(a)diku.dk>
>
> ---
> I wasn't able to find what security_task_setscheduler actually does.
> If it releases tasklist_lock in an error case, then ignire this patch.

Your patch appears correct - and mipsmt_sys_sched_setaffinity() even
more broken than you thought. It duplicates some code from kernel/sched.c
and has gotten out of sync.

Fixing that up.

Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] mm: provide init_mm mm_context initializer
Next: ath: Failed to stop TX DMA in 100 msec after killing last frame