arch/tile: Miscellaneous cleanup changes.
in [Kernel]
|
Prev: cache last free vmap_area to avoid restarting beginning
Next: V4L/uvcvideo: Add support for Suyin Corp. Lenovo Webcam
From: Arnd Bergmann on 26 Jun 2010 06:00 On Friday 25 June 2010, Chris Metcalf wrote: > This commit is primarily changes caused by reviewing "sparse" > and "checkpatch" output on our sources, so is somewhat noisy, since > things like "printk() -> pr_err()" (or whatever) throughout the > codebase tend to get tedious to read. Rather than trying to tease > apart precisely which things changed due to which type of code > review, this commit includes various cleanups in the code: > > - sparse: Add declarations in headers for globals. > - sparse: Fix __user annotations. > - sparse: Using gfp_t consistently instead of int. > - sparse: removing functions not actually used. > - checkpatch: Clean up printk() warnings by using pr_info(), etc.; > also avoid partial-line printks except in bootup code. > - checkpatch: Use exposed structs rather than typedefs. > - checkpatch: Change some C99 comments to C89 comments. > > In addition, a couple of minor other changes are rolled in > to this commit: > > - Add support for a "raise" instruction to cause SIGFPE, etc., to be raised. > - Remove some compat code that is unnecessary when we fully eliminate > some of the deprecated syscalls from the generic syscall ABI. > - Update the tile_defconfig to reflect current config contents. > > Signed-off-by: Chris Metcalf <cmetcalf(a)tilera.com> Hi Chris, As far as I can tell, all the changes in this patch look reasonable, but as a rule you should never mix functional changes and cleanups in a single patch. This is both for review purposes as well as for being able to bisect specific regressions that might be introduced by the patch. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Chris Metcalf on 27 Jun 2010 12:50
On 6/26/2010 5:56 AM, Arnd Bergmann wrote: > As far as I can tell, all the changes in this patch look reasonable, but > as a rule you should never mix functional changes and cleanups in a single > patch. This is both for review purposes as well as for being able to bisect > specific regressions that might be introduced by the patch. > Yes, I'll try to be more precise with my commits in the future. I was playing catch-up with a bunch of commits in our internal tree, which uses Perforce. The change migration process doesn't lend itself to pulling individual commits out of Perforce and into git, and I also worried about spamming LKML with dozens of small patches for the tile architecture, which after all hasn't even been pulled into Linus's tree yet. And, of course, since few if any folks are actually running these bits on their hardware yet (our hardware customers are likely all running the sources we ship them), the bisection issue is less critical. But I will at least make sure to separate out cleanups and bugfixes going forward. Thanks! -- Chris Metcalf, Tilera Corp. http://www.tilera.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |