From: Borislav Petkov on
From: Kulikov Vasiliy <segooon(a)gmail.com>
Date: Sat, Jul 03, 2010 at 12:03:59PM -0400

> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>

Acked-by: Borislav Petkov <borislav.petkov(a)amd.com>

> ---
> arch/x86/kernel/k8.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/k8.c b/arch/x86/kernel/k8.c
> index 0f7bc20..0ea4b35 100644
> --- a/arch/x86/kernel/k8.c
> +++ b/arch/x86/kernel/k8.c
> @@ -27,11 +27,10 @@ EXPORT_SYMBOL(k8_northbridges);
>
> static struct pci_dev *next_k8_northbridge(struct pci_dev *dev)
> {
> - do {
> - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
> - if (!dev)
> + for_each_pci_dev(dev) {
> + if (pci_match_id(&k8_nb_ids[0], dev))
> break;
> - } while (!pci_match_id(&k8_nb_ids[0], dev));
> + }
> return dev;
> }
>
> --
> 1.7.0.4
>
>

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Roedel, Joerg on
On Sat, Jul 03, 2010 at 12:03:51PM -0400, Kulikov Vasiliy wrote:
> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>
> ---
> arch/x86/kernel/amd_iommu.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
> index 0d20286..29dd3b9 100644
> --- a/arch/x86/kernel/amd_iommu.c
> +++ b/arch/x86/kernel/amd_iommu.c
> @@ -2609,8 +2609,7 @@ int __init amd_iommu_init_passthrough(void)
>
> pt_domain->mode |= PAGE_MODE_NONE;
>
> - while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> -
> + for_each_pci_dev(dev) {
> if (!check_device(&dev->dev))
> continue;

Applied, thanks.

--
Joerg Roedel - AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/