Prev: powerpc: Simplify update_vsyscall
Next: [PATCH 03/15] include spinlock.h
From: Mike Frysinger on 27 Jul 2010 20:00
On Tue, Jul 27, 2010 at 19:18, Andrew Morton wrote:
> On Mon, 26 Jul 2010 10:49:50 +0200 Michal Simek wrote:
>> start/stop_critical_timing function for preemptirqsoff, preemptoff
>> and irqsoff tracers contains atomic_inc and atomic_dec operations.
>>
>> Atomic operations used local_irq_save/restore macros to ensure
>> atomic access but they are traced by the same function which is causing
>> recursion problem.
>>
>> The reason is when these tracers are turn ON then local_irq_save/restore
>> macros are changed in include/linux/irqflags.h to call trace_hardirqs_on/off
>> which call start/stop_critical_timing.
>>
>> Microblaze was affected because use generic atomic implementation.
>
> Seems that this will also affect blackfin, mn10300 and score.  I guess
> they aren't supporting tracing yet?

do you mean TRACE_IRQFLAGS_SUPPORT ? Blackfin should ... my
understanding was that arches just needed to implement asm/irqflags.h
for it.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Mike Frysinger on 28 Jul 2010 01:40
On Wed, Jul 28, 2010 at 01:20, Michal Simek wrote:
> Andrew Morton wrote:
>> On Mon, 26 Jul 2010 10:49:50 +0200 Michal Simek wrote:
>>> Signed-off-by: Michal Simek <monstr(a)monstr.eu>
>>> Acked-by: Steven Rostedt <rostedt(a)goodmis.org>
>>> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org>
>>
>> hm, I wonder how my signoff got there.  Doesn't matter.
>
> http://lkml.org/lkml/2010/5/26/364

Sighed != Signed ;)
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: powerpc: Simplify update_vsyscall
Next: [PATCH 03/15] include spinlock.h