Prev: workqueue: update cwq alignement
Next: [PATCH] VMware balloon: force compiling as a module
From: David Howells on 29 Jun 2010 17:40
Tejun Heo <tj(a)kernel.org> wrote:

> Hmmm... workqueue workers are bound to certain cpu, so if you schedule
> a work on a specific CPU, it will run there.

That's my main problem with using cmwq to replace slow-work.

> Once a cpu gets saturated, the issuing thread will be moved elsewhere.

Assuming that the issuing thread isn't bound by the condition specified in the
previous sentence...

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Stefan Richter on 2 Jul 2010 11:20
Tejun Heo wrote:
> Replace private worker pool with system_long_wq.

system_unbound_wq actually.

> --- a/kernel/async.c
> +++ b/kernel/async.c
> @@ -49,40 +49,32 @@ asynchronous and synchronous parts of the kernel.
> */
>
> #include <linux/async.h>
> -#include <linux/bug.h>
> #include <linux/module.h>
> #include <linux/wait.h>
> #include <linux/sched.h>
> -#include <linux/init.h>
> -#include <linux/kthread.h>
> -#include <linux/delay.h>
> #include <linux/slab.h>
> #include <asm/atomic.h>
>

Shouldn't it include linux/workqueue.h now?
--
Stefan Richter
-=====-==-=- -=== ---=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Tejun Heo on 2 Jul 2010 12:30
On 07/02/2010 05:09 PM, Stefan Richter wrote:
> Tejun Heo wrote:
>> Replace private worker pool with system_long_wq.
>
> system_unbound_wq actually.
>
>> --- a/kernel/async.c
>> +++ b/kernel/async.c
>> @@ -49,40 +49,32 @@ asynchronous and synchronous parts of the kernel.
>> */
>>
>> #include <linux/async.h>
>> -#include <linux/bug.h>
>> #include <linux/module.h>
>> #include <linux/wait.h>
>> #include <linux/sched.h>
>> -#include <linux/init.h>
>> -#include <linux/kthread.h>
>> -#include <linux/delay.h>
>> #include <linux/slab.h>
>> #include <asm/atomic.h>
>>
>
> Shouldn't it include linux/workqueue.h now?

Updated. Thanks a lot.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2 3 4
Prev: workqueue: update cwq alignement
Next: [PATCH] VMware balloon: force compiling as a module