Prev: [037/139] ALSA: hda - Add MSI blacklist for Aopen MZ915-M
Next: [064/139] hwmon: (sht15) Fix sht15_calc_temp interpolation function
From: Evan McClain on 22 Apr 2010 16:30
On Thu, Apr 22, 2010 at 12:08:22PM -0700, Greg KH wrote:
> 2.6.32-stable review patch. If anyone has any objections, please let us know.

Apparently the MacBook1,1 reports the manufacturer as Apple Computer, Inc.

A patch was submitted here: http://lkml.org/lkml/2010/3/23/412

Steffen Röcker wasn't sure about the MacBook2,1 but according to sample
dmidecode outputs:
http://www.mail-archive.com/linux-acpi(a)vger.kernel.org/msg07914.html
and
http://www.mail-archive.com/linux-acpi(a)vger.kernel.org/msg09304.html
for MacBook1,1 and MacBook2,1 systems respectively, MacBook2,1 reports
as Apple Inc. as in my original patch.

Sorry for not catching this earlier.
--
Evan McClain
Aerospace Engineering
Graduate Student Senator .
evan.mcclain(a)gatech.edu ..:
From: Greg KH on 23 Apr 2010 12:10
On Thu, Apr 22, 2010 at 03:54:13PM -0400, Evan McClain wrote:
> On Thu, Apr 22, 2010 at 12:08:22PM -0700, Greg KH wrote:
> > 2.6.32-stable review patch. If anyone has any objections, please let us know.
>
> Apparently the MacBook1,1 reports the manufacturer as Apple Computer, Inc.
>
> A patch was submitted here: http://lkml.org/lkml/2010/3/23/412
>
> Steffen R�cker wasn't sure about the MacBook2,1 but according to sample
> dmidecode outputs:
> http://www.mail-archive.com/linux-acpi(a)vger.kernel.org/msg07914.html
> and
> http://www.mail-archive.com/linux-acpi(a)vger.kernel.org/msg09304.html
> for MacBook1,1 and MacBook2,1 systems respectively, MacBook2,1 reports
> as Apple Inc. as in my original patch.
>
> Sorry for not catching this earlier.

I don't understand, is this patch not correct? Should I drop it from
the stable release?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Evan McClain on 23 Apr 2010 13:00
On Fri, Apr 23, 2010 at 09:02:27AM -0700, Greg KH wrote:
> I don't understand, is this patch not correct? Should I drop it from
> the stable release?

It is correct, but it will not match MacBook1,1s as intended due to
apple changing vendor names.

--
Evan McClain
Aerospace Engineering
Graduate Student Senator .
evan.mcclain(a)gatech.edu ..:
From: Evan McClain on 23 Apr 2010 13:10
On Fri, Apr 23, 2010 at 12:49:46PM -0400, Evan McClain wrote:
> On Fri, Apr 23, 2010 at 09:02:27AM -0700, Greg KH wrote:
> > I don't understand, is this patch not correct? Should I drop it from
> > the stable release?
>
> It is correct, but it will not match MacBook1,1s as intended due to
> apple changing vendor names.

And by correct, I mean it would be correct if it only claimed to add
four MacBook variants instead of five.

--
Evan McClain
Aerospace Engineering
Graduate Student Senator .
evan.mcclain(a)gatech.edu ..:
 | 
Pages: 1
Prev: [037/139] ALSA: hda - Add MSI blacklist for Aopen MZ915-M
Next: [064/139] hwmon: (sht15) Fix sht15_calc_temp interpolation function