bfa: wrong fcport H2I message tested in bfa_fcport_isr()
in [Kernel]
|
Prev: Compile error in latest -git: ipc/syscall.c:17: error: conflicting types for ‘sys_ipc’
Next: [PATCH 1/2] cgroups: read-write lock CLONE_THREAD forking per threadgroup
From: Jing Huang on 22 Mar 2010 19:50 This is not intended. Using penable_rsp or pdisable_rsp in this case doesn't have functional difference since it is a union, but it is confusing and should be fixed. Thanks Jing -----Original Message----- From: Roel Kluin [mailto:roel.kluin(a)gmail.com] Sent: Monday, March 22, 2010 1:49 PM To: Jing Huang; linux-scsi(a)vger.kernel.org; Andrew Morton; LKML Subject: [PATCH] bfa: wrong fcport H2I message tested in bfa_fcport_isr() It appears that the wrong fcport H2I message was tested Signed-off-by: Roel Kluin <roel.kluin(a)gmail.com> --- Was this intended? diff --git a/drivers/scsi/bfa/bfa_fcport.c b/drivers/scsi/bfa/bfa_fcport.c index c589488..5e5e6fe 100644 --- a/drivers/scsi/bfa/bfa_fcport.c +++ b/drivers/scsi/bfa/bfa_fcport.c @@ -1281,7 +1281,7 @@ bfa_fcport_isr(struct bfa_s *bfa, struct bfi_msg_s *msg) break; case BFI_FCPORT_I2H_DISABLE_RSP: - if (fcport->msgtag == i2hmsg.penable_rsp->msgtag) + if (fcport->msgtag == i2hmsg.pdisable_rsp->msgtag) bfa_sm_send_event(fcport, BFA_FCPORT_SM_FWRSP); break; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |