cgroup: alloc_css_id() increments hierarchy depth
in [Kernel]
|
From: Paul Menage on 28 May 2010 18:30 On Fri, May 28, 2010 at 8:16 AM, Greg Thelen <gthelen(a)google.com> wrote: > > Signed-off-by: Greg Thelen <gthelen(a)google.com> Acked-by: Paul Menage <menage(a)google.com> Good catch, thanks. Paul > --- > �kernel/cgroup.c | � �2 +- > �1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 422cb19..3ac6f5b 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -4598,7 +4598,7 @@ static int alloc_css_id(struct cgroup_subsys *ss, struct cgroup *parent, > � � � �parent_css = parent->subsys[subsys_id]; > � � � �child_css = child->subsys[subsys_id]; > � � � �parent_id = parent_css->id; > - � � � depth = parent_id->depth; > + � � � depth = parent_id->depth + 1; > > � � � �child_id = get_new_cssid(ss, depth); > � � � �if (IS_ERR(child_id)) > -- > 1.7.0.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: KAMEZAWA Hiroyuki on 30 May 2010 20:00 On Fri, 28 May 2010 15:25:08 -0700 Paul Menage <menage(a)google.com> wrote: > On Fri, May 28, 2010 at 8:16 AM, Greg Thelen <gthelen(a)google.com> wrote: > > > > Signed-off-by: Greg Thelen <gthelen(a)google.com> > > Acked-by: Paul Menage <menage(a)google.com> > > Good catch, thanks. > Nice Catch. Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> But, who breaks this ? Do we need backport this against old kernels ? 2.6.33 has this. > 3959 depth = css_depth(parent_css) + 1; > 3960 parent_id = parent_css->id; > 3961 > 3962 child_id = get_new_cssid(ss, depth); Thanks, -Kame > Paul > > > --- > > kernel/cgroup.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > > index 422cb19..3ac6f5b 100644 > > --- a/kernel/cgroup.c > > +++ b/kernel/cgroup.c > > @@ -4598,7 +4598,7 @@ static int alloc_css_id(struct cgroup_subsys *ss, struct cgroup *parent, > > parent_css = parent->subsys[subsys_id]; > > child_css = child->subsys[subsys_id]; > > parent_id = parent_css->id; > > - depth = parent_id->depth; > > + depth = parent_id->depth + 1; > > > > child_id = get_new_cssid(ss, depth); > > if (IS_ERR(child_id)) > > -- > > 1.7.0.1 > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: KAMEZAWA Hiroyuki on 30 May 2010 20:50 On Sun, 30 May 2010 17:44:34 -0700 Greg Thelen <gthelen(a)google.com> wrote: > On Sun, May 30, 2010 at 4:54 PM, KAMEZAWA Hiroyuki > <kamezawa.hiroyu(a)jp.fujitsu.com> wrote: > > On Mon, 31 May 2010 08:45:29 +0900 > > KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> wrote: > > > >> On Fri, 28 May 2010 15:25:08 -0700 > >> Paul Menage <menage(a)google.com> wrote: > >> > >> > On Fri, May 28, 2010 at 8:16 AM, Greg Thelen <gthelen(a)google.com> wrote: > >> > > > >> > > Signed-off-by: Greg Thelen <gthelen(a)google.com> > >> > > >> > Acked-by: Paul Menage <menage(a)google.com> > >> > > >> > Good catch, thanks. > >> > > >> Nice Catch. > >> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> > >> > >> But, who breaks this ? Do we need backport this against old kernels ? > >> > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fae9c791703606636c1220e47f6690660042ce7f > > > > Hmm. this one. and 2.6.34 needs this patch. Greg, could you post this to > > stable-2.6.34 tree ? > > Given that I forgot to include "Cc: stable <stable(a)kernel.org>" in the > patch, I assume the best way to get this patch into -stable is for me > to email the commit id to stable(a)kernel.org once the patch is accepted > into Linus' tree. Let me know if there is a better way. > Yes, it's best to CC stable(a)kernel.org. But please specify what version of kernels requires this patch as "for 2.6.34" Thank you, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg Thelen on 30 May 2010 20:50 On Sun, May 30, 2010 at 4:54 PM, KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> wrote: > On Mon, 31 May 2010 08:45:29 +0900 > KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> wrote: > >> On Fri, 28 May 2010 15:25:08 -0700 >> Paul Menage <menage(a)google.com> wrote: >> >> > On Fri, May 28, 2010 at 8:16 AM, Greg Thelen <gthelen(a)google.com> wrote: >> > > >> > > Signed-off-by: Greg Thelen <gthelen(a)google.com> >> > >> > Acked-by: Paul Menage <menage(a)google.com> >> > >> > Good catch, thanks. >> > >> Nice Catch. >> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> >> >> But, who breaks this ? Do we need backport this against old kernels ? >> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fae9c791703606636c1220e47f6690660042ce7f > > Hmm. this one. and 2.6.34 needs this patch. Greg, could you post this to > stable-2.6.34 tree ? Given that I forgot to include "Cc: stable <stable(a)kernel.org>" in the patch, I assume the best way to get this patch into -stable is for me to email the commit id to stable(a)kernel.org once the patch is accepted into Linus' tree. Let me know if there is a better way. -- Greg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Li Zefan on 30 May 2010 21:00 >>>> On Fri, May 28, 2010 at 8:16 AM, Greg Thelen <gthelen(a)google.com> wrote: >>>>> Signed-off-by: Greg Thelen <gthelen(a)google.com> >>>> Acked-by: Paul Menage <menage(a)google.com> >>>> >>>> Good catch, thanks. >>>> >>> Nice Catch. >>> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com> >>> >>> But, who breaks this ? Do we need backport this against old kernels ? >>> >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fae9c791703606636c1220e47f6690660042ce7f >> >> Hmm. this one. and 2.6.34 needs this patch. Greg, could you post this to >> stable-2.6.34 tree ? > > Given that I forgot to include "Cc: stable <stable(a)kernel.org>" in the > patch, I assume the best way to get this patch into -stable is for me > to email the commit id to stable(a)kernel.org once the patch is accepted > into Linus' tree. Let me know if there is a better way. > I think Andrew will mark it and send it to stable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: [PATCH] rapidio: fix new kernel-doc warnings Next: ACPI patches for 2.6.35-merge |