Prev: [PATCH 2/3] hid: add suspend/resume hooks for hid drivers
Next: udf: use ext2_find_next_bit
From: Paul Menage on 24 Feb 2010 11:10
On Wed, Feb 24, 2010 at 5:28 AM, Kirill A. Shutemov
<kirill(a)shutemov.name> wrote:
>>
>> Using a single goto label to cleanup multi failure paths can
>> get things wrong quite easily, while multi labels makes the
>> code cleaner.
>
> I disagree.
> It's easer to make mistake on changing code with multi failure
> paths, if you want to move a code within function.

I'm on Kirill's side here. Being able to have a single "cleanup
everything" error path makes the code a lot more maintainable. It may
be inappropriate for really performance-critical functions, but that's
not the case here.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 2/3] hid: add suspend/resume hooks for hid drivers
Next: udf: use ext2_find_next_bit