Prev: [PATCH] flex_array: add helpers to get and put to make pointers easy to use
Next: [PATCH] arch/powerpc: Drop unnecessary of_node_put
From: Andrew Morton on 3 Aug 2010 16:00
On Fri, 30 Jul 2010 19:56:49 -0400
Ben Blum <bblum(a)andrew.cmu.edu> wrote:

> This patch series implements a write function for the 'cgroup.procs'
> per-cgroup file, which enables atomic movement of multithreaded
> applications between cgroups. Writing the thread-ID of any thread in a
> threadgroup to a cgroup's procs file causes all threads in the group to
> be moved to that cgroup safely with respect to threads forking/exiting.
> (Possible usage scenario: If running a multithreaded build system that
> sucks up system resources, this lets you restrict it all at once into a
> new cgroup to keep it under control.)

I can see how that would be useful. No comments from anyone else?

patch 1/2 makes me cry with all those ifdefs. Maybe helper functions
would help, but not a lot.

patch 2/2 looks very complicated.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: KAMEZAWA Hiroyuki on 3 Aug 2010 20:00
On Tue, 3 Aug 2010 12:58:27 -0700
Andrew Morton <akpm(a)linux-foundation.org> wrote:

> On Fri, 30 Jul 2010 19:56:49 -0400
> Ben Blum <bblum(a)andrew.cmu.edu> wrote:
>
> > This patch series implements a write function for the 'cgroup.procs'
> > per-cgroup file, which enables atomic movement of multithreaded
> > applications between cgroups. Writing the thread-ID of any thread in a
> > threadgroup to a cgroup's procs file causes all threads in the group to
> > be moved to that cgroup safely with respect to threads forking/exiting.
> > (Possible usage scenario: If running a multithreaded build system that
> > sucks up system resources, this lets you restrict it all at once into a
> > new cgroup to keep it under control.)
>
> I can see how that would be useful. No comments from anyone else?
>

I think the feature itself is good and useful. I welcome this.

> patch 1/2 makes me cry with all those ifdefs. Maybe helper functions
> would help, but not a lot.
>
Add static inline functions ?


> patch 2/2 looks very complicated.

yes. that's a concern.
I'd like to look deeper, today.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] flex_array: add helpers to get and put to make pointers easy to use
Next: [PATCH] arch/powerpc: Drop unnecessary of_node_put