Prev: cifs: define superblock-level cache index objects and register them
Next: cifs: define server-level cache index objects and register them with FS-Cache
From: David Howells on 23 Jun 2010 13:00
Suresh Jayaraman <sjayaraman(a)suse.de> wrote:

> + rc = cifs_fscache_register();
> + if (rc)
> + goto out;
> +
> rc = cifs_init_inodecache();
> if (rc)
> goto out_clean_proc;
> @@ -949,8 +954,10 @@ init_cifs(void)
> cifs_destroy_mids();
> out_destroy_inodecache:
> cifs_destroy_inodecache();
> + cifs_fscache_unregister();
> out_clean_proc:

This is incorrect. You need to call cifs_fscache_unregister() if
cifs_init_inodecache() fails.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Suresh Jayaraman on 25 Jun 2010 07:00
On 06/23/2010 10:21 PM, David Howells wrote:
> Suresh Jayaraman <sjayaraman(a)suse.de> wrote:
>
>> + rc = cifs_fscache_register();
>> + if (rc)
>> + goto out;
>> +
>> rc = cifs_init_inodecache();
>> if (rc)
>> goto out_clean_proc;
>> @@ -949,8 +954,10 @@ init_cifs(void)
>> cifs_destroy_mids();
>> out_destroy_inodecache:
>> cifs_destroy_inodecache();
>> + cifs_fscache_unregister();
>> out_clean_proc:
>
> This is incorrect. You need to call cifs_fscache_unregister() if
> cifs_init_inodecache() fails.
>

Doh! I'll fix it.


--
Suresh Jayaraman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: cifs: define superblock-level cache index objects and register them
Next: cifs: define server-level cache index objects and register them with FS-Cache