commit 9630bdd9 changes behavior of the poweroff - bug?
in [Kernel]
|
Prev: [PATCH] proc: Report file name on detected read_proc overflow
Next: [PATCH] hwmon: sht15: Fix sht15_calc_temp interpolation function
From: Rafael J. Wysocki on 13 Apr 2010 16:00 On Tuesday 13 April 2010, Michal Hocko wrote: > On Tue 13-04-10 01:01:54, Rafael J. Wysocki wrote: > > On Saturday 10 April 2010, Rafael J. Wysocki wrote: > > > On Friday 09 April 2010, Tony Vroon wrote: > > > > On Fri, 2010-04-09 at 22:42 +0200, Rafael J. Wysocki wrote: > > > > > Please check if the patch below changes anything. > > > > > drivers/acpi/wakeup.c | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > That didn't change the behaviour for me, sorry. > > > > > > Well, I would be sorry if it did, because the patch removed some useful code. :-) > > > > > > > (I made sure to go through a full power down session before trying the > > > > patched kernel) > > > > > > Thanks for testing. So it looks like we don't disable the GPE during power off. > > > > > > I'll try to figure out what's going on, please stay tuned. > > > > Can you please check if the patch below changes the behavior? > > Unfortunately, it didn't help either (I have tried on top of the fresh > rc4). That gets really weird. > > --- > > drivers/acpi/wakeup.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Index: linux-2.6/drivers/acpi/wakeup.c > > =================================================================== > > --- linux-2.6.orig/drivers/acpi/wakeup.c > > +++ linux-2.6/drivers/acpi/wakeup.c > > @@ -63,17 +63,17 @@ void acpi_enable_wakeup_device(u8 sleep_ > > list_for_each_safe(node, next, &acpi_wakeup_device_list) { > > struct acpi_device *dev = > > container_of(node, struct acpi_device, wakeup_list); > > + u8 action = ACPI_GPE_ENABLE; Can you try to change the above to ACPI_GPE_DISABLE and retest, please? > > if (!dev->wakeup.flags.valid) > > continue; > > > > if ((!dev->wakeup.state.enabled && !dev->wakeup.prepare_count) > > || sleep_state > (u32) dev->wakeup.sleep_state) > > - continue; > > + action = ACPI_GPE_DISABLE; > > > > - /* The wake-up power should have been enabled already. */ > > acpi_set_gpe(dev->wakeup.gpe_device, dev->wakeup.gpe_number, > > - ACPI_GPE_ENABLE); > > + action); > > } > > } Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michal Hocko on 14 Apr 2010 04:00 On Tue 13-04-10 22:53:37, Rafael J. Wysocki wrote: > On Tuesday 13 April 2010, Michal Hocko wrote: > > On Tue 13-04-10 01:01:54, Rafael J. Wysocki wrote: > > > On Saturday 10 April 2010, Rafael J. Wysocki wrote: > > > > On Friday 09 April 2010, Tony Vroon wrote: > > > > > On Fri, 2010-04-09 at 22:42 +0200, Rafael J. Wysocki wrote: > > > > > > Please check if the patch below changes anything. > > > > > > drivers/acpi/wakeup.c | 4 ++-- > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > That didn't change the behaviour for me, sorry. > > > > > > > > Well, I would be sorry if it did, because the patch removed some useful code. :-) > > > > > > > > > (I made sure to go through a full power down session before trying the > > > > > patched kernel) > > > > > > > > Thanks for testing. So it looks like we don't disable the GPE during power off. > > > > > > > > I'll try to figure out what's going on, please stay tuned. > > > > > > Can you please check if the patch below changes the behavior? > > > > Unfortunately, it didn't help either (I have tried on top of the fresh > > rc4). > > That gets really weird. > > > > --- > > > drivers/acpi/wakeup.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > Index: linux-2.6/drivers/acpi/wakeup.c > > > =================================================================== > > > --- linux-2.6.orig/drivers/acpi/wakeup.c > > > +++ linux-2.6/drivers/acpi/wakeup.c > > > @@ -63,17 +63,17 @@ void acpi_enable_wakeup_device(u8 sleep_ > > > list_for_each_safe(node, next, &acpi_wakeup_device_list) { > > > struct acpi_device *dev = > > > container_of(node, struct acpi_device, wakeup_list); > > > + u8 action = ACPI_GPE_ENABLE; > > Can you try to change the above to ACPI_GPE_DISABLE and retest, please? Unfortunately didn't help as well... Just for reference: diff --git a/drivers/acpi/wakeup.c b/drivers/acpi/wakeup.c index 248b473..f23c08f 100644 --- a/drivers/acpi/wakeup.c +++ b/drivers/acpi/wakeup.c @@ -63,7 +63,7 @@ void acpi_enable_wakeup_device(u8 sleep_state) list_for_each_safe(node, next, &acpi_wakeup_device_list) { struct acpi_device *dev = container_of(node, struct acpi_device, wakeup_list); - u8 action = ACPI_GPE_ENABLE; + u8 action = ACPI_GPE_DISABLE; if (!dev->wakeup.flags.valid) continue; > > > > if (!dev->wakeup.flags.valid) > > > continue; > > > > > > if ((!dev->wakeup.state.enabled && !dev->wakeup.prepare_count) > > > || sleep_state > (u32) dev->wakeup.sleep_state) > > > - continue; > > > + action = ACPI_GPE_DISABLE; > > > > > > - /* The wake-up power should have been enabled already. */ > > > acpi_set_gpe(dev->wakeup.gpe_device, dev->wakeup.gpe_number, > > > - ACPI_GPE_ENABLE); > > > + action); > > > } > > > } > > Rafael -- Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Rafael J. Wysocki on 16 Apr 2010 14:00 On Wednesday 14 April 2010, Michal Hocko wrote: > On Tue 13-04-10 22:53:37, Rafael J. Wysocki wrote: > > On Tuesday 13 April 2010, Michal Hocko wrote: > > > On Tue 13-04-10 01:01:54, Rafael J. Wysocki wrote: > > > > On Saturday 10 April 2010, Rafael J. Wysocki wrote: > > > > > On Friday 09 April 2010, Tony Vroon wrote: > > > > > > On Fri, 2010-04-09 at 22:42 +0200, Rafael J. Wysocki wrote: > > > > > > > Please check if the patch below changes anything. > > > > > > > drivers/acpi/wakeup.c | 4 ++-- > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > That didn't change the behaviour for me, sorry. > > > > > > > > > > Well, I would be sorry if it did, because the patch removed some useful code. :-) > > > > > > > > > > > (I made sure to go through a full power down session before trying the > > > > > > patched kernel) > > > > > > > > > > Thanks for testing. So it looks like we don't disable the GPE during power off. > > > > > > > > > > I'll try to figure out what's going on, please stay tuned. > > > > > > > > Can you please check if the patch below changes the behavior? > > > > > > Unfortunately, it didn't help either (I have tried on top of the fresh > > > rc4). > > > > That gets really weird. > > > > > > --- > > > > drivers/acpi/wakeup.c | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > Index: linux-2.6/drivers/acpi/wakeup.c > > > > =================================================================== > > > > --- linux-2.6.orig/drivers/acpi/wakeup.c > > > > +++ linux-2.6/drivers/acpi/wakeup.c > > > > @@ -63,17 +63,17 @@ void acpi_enable_wakeup_device(u8 sleep_ > > > > list_for_each_safe(node, next, &acpi_wakeup_device_list) { > > > > struct acpi_device *dev = > > > > container_of(node, struct acpi_device, wakeup_list); > > > > + u8 action = ACPI_GPE_ENABLE; > > > > Can you try to change the above to ACPI_GPE_DISABLE and retest, please? > > Unfortunately didn't help as well... > Just for reference: > > diff --git a/drivers/acpi/wakeup.c b/drivers/acpi/wakeup.c > index 248b473..f23c08f 100644 > --- a/drivers/acpi/wakeup.c > +++ b/drivers/acpi/wakeup.c > @@ -63,7 +63,7 @@ void acpi_enable_wakeup_device(u8 sleep_state) > list_for_each_safe(node, next, &acpi_wakeup_device_list) { > struct acpi_device *dev = > container_of(node, struct acpi_device, wakeup_list); > - u8 action = ACPI_GPE_ENABLE; > + u8 action = ACPI_GPE_DISABLE; That probably means the chipset enables the GPEs by itself _after_ we've disabled them in acpi_enable_wakeup_device(). Unfortunately, I can't reproduce the issue on any of my test boxes and it's hard to find the source of the problem staring at the code. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Michal Hocko on 19 Apr 2010 08:10 On Fri 16-04-10 20:00:29, Rafael J. Wysocki wrote: > On Wednesday 14 April 2010, Michal Hocko wrote: > > On Tue 13-04-10 22:53:37, Rafael J. Wysocki wrote: > > > On Tuesday 13 April 2010, Michal Hocko wrote: > > > > On Tue 13-04-10 01:01:54, Rafael J. Wysocki wrote: > > > > > On Saturday 10 April 2010, Rafael J. Wysocki wrote: > > > > > > On Friday 09 April 2010, Tony Vroon wrote: > > > > > > > On Fri, 2010-04-09 at 22:42 +0200, Rafael J. Wysocki wrote: > > > > > > > > Please check if the patch below changes anything. > > > > > > > > drivers/acpi/wakeup.c | 4 ++-- > > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > That didn't change the behaviour for me, sorry. > > > > > > > > > > > > Well, I would be sorry if it did, because the patch removed some useful code. :-) > > > > > > > > > > > > > (I made sure to go through a full power down session before trying the > > > > > > > patched kernel) > > > > > > > > > > > > Thanks for testing. So it looks like we don't disable the GPE during power off. > > > > > > > > > > > > I'll try to figure out what's going on, please stay tuned. > > > > > > > > > > Can you please check if the patch below changes the behavior? > > > > > > > > Unfortunately, it didn't help either (I have tried on top of the fresh > > > > rc4). > > > > > > That gets really weird. > > > > > > > > --- > > > > > drivers/acpi/wakeup.c | 6 +++--- > > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > > > Index: linux-2.6/drivers/acpi/wakeup.c > > > > > =================================================================== > > > > > --- linux-2.6.orig/drivers/acpi/wakeup.c > > > > > +++ linux-2.6/drivers/acpi/wakeup.c > > > > > @@ -63,17 +63,17 @@ void acpi_enable_wakeup_device(u8 sleep_ > > > > > list_for_each_safe(node, next, &acpi_wakeup_device_list) { > > > > > struct acpi_device *dev = > > > > > container_of(node, struct acpi_device, wakeup_list); > > > > > + u8 action = ACPI_GPE_ENABLE; > > > > > > Can you try to change the above to ACPI_GPE_DISABLE and retest, please? > > > > Unfortunately didn't help as well... > > Just for reference: > > > > diff --git a/drivers/acpi/wakeup.c b/drivers/acpi/wakeup.c > > index 248b473..f23c08f 100644 > > --- a/drivers/acpi/wakeup.c > > +++ b/drivers/acpi/wakeup.c > > @@ -63,7 +63,7 @@ void acpi_enable_wakeup_device(u8 sleep_state) > > list_for_each_safe(node, next, &acpi_wakeup_device_list) { > > struct acpi_device *dev = > > container_of(node, struct acpi_device, wakeup_list); > > - u8 action = ACPI_GPE_ENABLE; > > + u8 action = ACPI_GPE_DISABLE; > > That probably means the chipset enables the GPEs by itself _after_ we've > disabled them in acpi_enable_wakeup_device(). Is this something BIOS specific? > > Unfortunately, I can't reproduce the issue on any of my test boxes and it's > hard to find the source of the problem staring at the code. Are there any debug options I can turn on to provide some information? Btw. what exactly does this mean? In what state is the laptop while it is turned off and GPE is enabled? Thanks! > > Rafael -- Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Rafael J. Wysocki on 19 Apr 2010 11:20
On Monday 19 April 2010, Michal Hocko wrote: > On Fri 16-04-10 20:00:29, Rafael J. Wysocki wrote: > > On Wednesday 14 April 2010, Michal Hocko wrote: > > > On Tue 13-04-10 22:53:37, Rafael J. Wysocki wrote: > > > > On Tuesday 13 April 2010, Michal Hocko wrote: > > > > > On Tue 13-04-10 01:01:54, Rafael J. Wysocki wrote: > > > > > > On Saturday 10 April 2010, Rafael J. Wysocki wrote: > > > > > > > On Friday 09 April 2010, Tony Vroon wrote: > > > > > > > > On Fri, 2010-04-09 at 22:42 +0200, Rafael J. Wysocki wrote: > > > > > > > > > Please check if the patch below changes anything. > > > > > > > > > drivers/acpi/wakeup.c | 4 ++-- > > > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > That didn't change the behaviour for me, sorry. > > > > > > > > > > > > > > Well, I would be sorry if it did, because the patch removed some useful code. :-) > > > > > > > > > > > > > > > (I made sure to go through a full power down session before trying the > > > > > > > > patched kernel) > > > > > > > > > > > > > > Thanks for testing. So it looks like we don't disable the GPE during power off. > > > > > > > > > > > > > > I'll try to figure out what's going on, please stay tuned. > > > > > > > > > > > > Can you please check if the patch below changes the behavior? > > > > > > > > > > Unfortunately, it didn't help either (I have tried on top of the fresh > > > > > rc4). > > > > > > > > That gets really weird. > > > > > > > > > > --- > > > > > > drivers/acpi/wakeup.c | 6 +++--- > > > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > > > > > Index: linux-2.6/drivers/acpi/wakeup.c > > > > > > =================================================================== > > > > > > --- linux-2.6.orig/drivers/acpi/wakeup.c > > > > > > +++ linux-2.6/drivers/acpi/wakeup.c > > > > > > @@ -63,17 +63,17 @@ void acpi_enable_wakeup_device(u8 sleep_ > > > > > > list_for_each_safe(node, next, &acpi_wakeup_device_list) { > > > > > > struct acpi_device *dev = > > > > > > container_of(node, struct acpi_device, wakeup_list); > > > > > > + u8 action = ACPI_GPE_ENABLE; > > > > > > > > Can you try to change the above to ACPI_GPE_DISABLE and retest, please? > > > > > > Unfortunately didn't help as well... > > > Just for reference: > > > > > > diff --git a/drivers/acpi/wakeup.c b/drivers/acpi/wakeup.c > > > index 248b473..f23c08f 100644 > > > --- a/drivers/acpi/wakeup.c > > > +++ b/drivers/acpi/wakeup.c > > > @@ -63,7 +63,7 @@ void acpi_enable_wakeup_device(u8 sleep_state) > > > list_for_each_safe(node, next, &acpi_wakeup_device_list) { > > > struct acpi_device *dev = > > > container_of(node, struct acpi_device, wakeup_list); > > > - u8 action = ACPI_GPE_ENABLE; > > > + u8 action = ACPI_GPE_DISABLE; > > > > That probably means the chipset enables the GPEs by itself _after_ we've > > disabled them in acpi_enable_wakeup_device(). > > Is this something BIOS specific? > > > > > Unfortunately, I can't reproduce the issue on any of my test boxes and it's > > hard to find the source of the problem staring at the code. > > Are there any debug options I can turn on to provide some information? We can only check what the kernel tells us before power off, but all that seems correct. > Btw. what exactly does this mean? In what state is the laptop while it > is turned off and GPE is enabled? If a GPE is enabled, then some part of the chipset has power provided so that it can signal wakeup. I'll look into it a bit more later today. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |