From: Linus Torvalds on


On Mon, 17 May 2010, Ingo Molnar wrote:
>
> Tony Breeds (1):
> mutex: Fix optimistic spinning vs. BKL

Grr. This has the ugly timeout thing, but what's _really_ ugly about it is

kernel/mutex.c: In function �__mutex_lock_common�:
kernel/mutex.c:148: warning: unused variable �timeout�

Nasty. It happens when spinning is disabled due to lockdep or whatever
debugging that kills it.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Linus Torvalds on


On Tue, 18 May 2010, Ingo Molnar wrote:
>
> But we can also chop off the final commit and redo it
> without the jiffies timeout.

Ok. I pulled your top-commit-missing version instead. Thanks,

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Ingo Molnar on

* Linus Torvalds <torvalds(a)linux-foundation.org> wrote:

> On Tue, 18 May 2010, Ingo Molnar wrote:
> >
> > But we can also chop off the final commit and redo it
> > without the jiffies timeout.
>
> Ok. I pulled your top-commit-missing version instead. Thanks,

Thanks! Will handle the BKL/spin-mutex bug fix separately.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jaswinder Singh Rajput on
Hello Ingo,

On Tue, May 18, 2010 at 8:22 PM, Ingo Molnar <mingo(a)elte.hu> wrote:
>
> * Linus Torvalds <torvalds(a)linux-foundation.org> wrote:
>
>> On Mon, 17 May 2010, Ingo Molnar wrote:
>> >
>> > Tony Breeds (1):
>> > � � � mutex: Fix optimistic spinning vs. BKL
>>
>> Grr. This has the ugly timeout thing, but what's _really_ ugly about it is
>>
>> � � � kernel/mutex.c: In function �__mutex_lock_common�:
>> � � � kernel/mutex.c:148: warning: unused variable �timeout�
>>
>> Nasty. It happens when spinning is disabled due to
>> lockdep or whatever debugging that kills it.
>
> Sorry about that.
>

Sweet, you do not forgive others, but you expect that others forgive you.

--
Jaswinder Singh.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/