Prev: blk-cgroup: Fix RCU correctness warning in cfq_init_queue()
Next: add usb_add_bus() function for usb bus list
From: YuPing Luo on 21 Apr 2010 02:30
Hi,
I have one ARM11-based board, while upgrading the kernel from 27 to
32, got the workqueue recursion warning almost, and the console get
lost. While the issue can be resolved by applying the patch "[PATCH v2]
core: workqueue: return on workqueue recursion", and I am still
struggling to find the root cause.
Following are logs:(power on the modem, then gprs dial succ, unplug
it)

[14052.354076] usb 1-1: new high speed USB device using usbc and address
7
[14052.523956] usb 1-1: configuration #1 chosen from 1 choice
[14052.559707] option 1-1:1.1: GSM modem (1-port) converter detected
[14052.594464] usb 1-1: GSM modem (1-port) converter now attached to
ttyUSB0
[14052.624239] scsi5 : SCSI emulation for USB Mass Storage devices
[14052.692267] option 1-1:1.3: GSM modem (1-port) converter detected
[14052.754367] usb 1-1: GSM modem (1-port) converter now attached to
ttyUSB1

[14058.038563] scsi 5:0:0:0: Direct-Access USBModem Disk
2.31 PQ: 0 ANSI: 2
[14058.072847] sd 5:0:0:0: Attached scsi generic sg0 type 0
[14058.093247] sd 5:0:0:0: [sda] Attached SCSI removable disk
[14074.570071] flush_cpu_workqueue:cwq->thread [events/0],current [pppd]
[14083.842280] usb 1-1: USB disconnect, address 7
[14083.844571] option: option_instat_callback: error -108
[14083.855977] option_close
[14083.872270] option1 ttyUSB0: GSM modem (1-port) converter now
disconnected from ttyUSB0
[14083.892532] option_disconnect
[14083.892691] option 1-1:1.1: device disconnected
[14083.900518] binder_deferred_func:proc task [rild],current [events/0]
[14083.908593] flush_cpu_workqueue:cwq->thread [events/0],current
[events/0]
[14083.912553] ------------[ cut here ]------------
[14083.917336] WARNING: at
/home/ypluo/ws/L32EVB/Main/kernel/kernel/workqueue.c:370
flush_cpu_workqueue+0xd0/0xf0()
[14083.927344] Modules linked in: usb_storage sd_mod scsi_wait_scan sg
scsi_mod dm9000 pvrmved sirfsoc_vpp sirfsoc_wdt sirfsoc_uspserial
g_ether g_file_storc
[14083.957425] Backtrace:
[14083.959898] [<c008dd0c>] (dump_backtrace+0x0/0x118) from [<c008de58>]
(dump_stack+0x18/0x1c)
[14083.968312] r7:00000000 r6:c00c43d8 r5:c036ec48 r4:00000172
[14083.973959] [<c008de40>] (dump_stack+0x0/0x1c) from [<c00acab0>]
(warn_slowpath_common+0x50/0x68)
[14083.982825] [<c00aca60>] (warn_slowpath_common+0x0/0x68) from
[<c00acae0>] (warn_slowpath_null+0x18/0x1c)
[14083.992354] r7:00000000 r6:c782c000 r5:c7801920 r4:c782c000
[14083.997981] [<c00acac8>] (warn_slowpath_null+0x0/0x1c) from
[<c00c43d8>] (flush_cpu_workqueue+0xd0/0xf0)
[14084.007465] [<c00c4308>] (flush_cpu_workqueue+0x0/0xf0) from
[<c00c4534>] (flush_workqueue+0x14/0x18)
[14084.016655] r5:c710d814 r4:c710d800
[14084.020197] [<c00c4520>] (flush_workqueue+0x0/0x18) from [<c00c4550>]
(flush_scheduled_work+0x18/0x20)
[14084.029535] [<c00c4538>] (flush_scheduled_work+0x0/0x20) from
[<c02251c8>] (tty_ldisc_release+0x20/0x70)
[14084.038980] [<c02251a8>] (tty_ldisc_release+0x0/0x70) from
[<c021eff8>] (tty_release_dev+0x33c/0x490)
[14084.048161] r7:c67f3ec0 r6:c782c000 r5:c710d800 r4:00000000
[14084.053790] [<c021ecbc>] (tty_release_dev+0x0/0x490) from
[<c021f168>] (tty_release+0x1c/0x28)
[14084.062424] [<c021f14c>] (tty_release+0x0/0x28) from [<c01318dc>]
(__fput+0xe0/0x210)
[14084.070212] r5:00000008 r4:c67f3ec0
[14084.073756] [<c01317fc>] (__fput+0x0/0x210) from [<c0131f4c>]
(fput+0x30/0x34)
[14084.080986] [<c0131f1c>] (fput+0x0/0x34) from [<c012e430>]
(filp_close+0x60/0x84)
[14084.088477] [<c012e3d0>] (filp_close+0x0/0x84) from [<c00aec64>]
(put_files_struct+0xdc/0xec)
[14084.096946] r7:c78a6e40 r6:c78a6e48 r5:00000000 r4:00000001
[14084.102592] [<c00aeb88>] (put_files_struct+0x0/0xec) from
[<c0278ba8>] (binder_deferred_func+0x470/0x62c)
[14084.112140] r9:c03cf1e0 r8:c7997200 r7:c7816360 r6:c7801920
r5:00000001
[14084.118613] r4:00000000
[14084.121241] [<c0278738>] (binder_deferred_func+0x0/0x62c) from
[<c00c56b0>] (worker_thread+0x158/0x2b8)
[14084.130648] [<c00c5558>] (worker_thread+0x0/0x2b8) from [<c00c946c>]
(kthread+0x88/0x90)
[14084.138708] [<c00c93e4>] (kthread+0x0/0x90) from [<c00b0008>]
(do_exit+0x0/0x700)
[14084.146157] r6:00000000 r5:00000000 r4:00000000
[14084.150733] ---[ end trace 08510fb4b295aa33 ]---
[14084.524672] option_release
[14084.524846] option_close
[14084.555312] option1 ttyUSB1: GSM modem (1-port) converter now
disconnected from ttyUSB1
[14084.582033] option_disconnect
[14084.582186] option 1-1:1.3: device disconnected

# [14085.794313] flush_cpu_workqueue:cwq->thread [events/0],current
[pppd]
[14085.797985] option_release

one user-mode daemon will get the unplug event, and close the two
usb-serial ports,then the daemon itself.
if ignore the uevent, everyting is ok.

thanks.
Yuping


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: YuPing Luo on 21 Apr 2010 23:30
> > On Tue, Apr 20, 2010 at 11:27:55PM -0700, YuPing Luo wrote:
> Is your console on a usb to serial device? Or a serial port?
> if usb to serial, can you try .33-rc5 and let us know if that solves
the problem?
> greg k-h

The console is over serial port, while the usb modem exported 2 serial
ports .
The recursion can be avoided if introducing one dedicated work queue
thread for binder (
http://android.git.kernel.org/?p=kernel/common.git;a=blob;f=drivers/stag
ing/android/binder.c;h=99010d4b3044b2c33c9d709e334b5be7871b9599;hb=andro
id-2.6.32).

Thanks
Yuping


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: YuPing Luo on 22 Apr 2010 22:50
From: Arve Hj�nnev�g [mailto:arve(a)android.com] Sent: Friday, April 23, 2010 7:28 AM
> I don't think this is related to your console. I could easily
> reproduce your problem by killing rild (which uses both the binder and
> ttys). You may also what to find out why your rild is exiting.

I make the rild service stopped while vold daemon detect usb-modem unplugged.

>> �The recursion can be avoided if introducing one dedicated work queue
>> thread for binder
> I just pushed a fix that does exactly that.
Good news, and just confused while the workqueue introduced in binder, why the tty_release() triggered by its work handler, the normal case looks like following:

(tty_release+0x1c/0x28)
[ 68.068397] [<c021f16c>] (tty_release+0x0/0x28) from [<c01318f8>] (__fput+0xe0/0x210)
[ 68.076177] r5:00000008 r4:c69009c0
.......
[ 68.102362] r7:00000006 r6:c69009c0 r5:c78a60c0 r4:c281e000
[ 68.108026] [<c012f748>] (sys_close+0x0/0x110) from [<c0089f40>] (ret_fast_syscall+0x0/0x2c)
[ 68.116453] r7:00000006 r6:0002ac60 r5:00000010 r4:0002ef08
[ 68.122068] ---[ end trace 6c2209be9c1c296c ]---
[ 68.234009] option_release

Thanks
Yuping


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: blk-cgroup: Fix RCU correctness warning in cfq_init_queue()
Next: add usb_add_bus() function for usb bus list