From: Mikael Starvik on
Sure, if you feel like its worth it. If we can't allocate one page of data in an init function we are probably up for more problems soon...

Signed-off-by: Mikael Starvik <starvik(a)axis.com>

-----Original Message-----
From: Steven Liu [mailto:lingjiujianke(a)gmail.com]
Sent: den 18 maj 2010 08:26
To: Mikael Starvik; Jesper Nilsson; linux-kernel(a)vger.kernel.org; linux-cris-kernel; liuqi(a)thunderst.com
Subject: [PATCH] cris:Check kmalloc return value before use data

Check kmalloc return value before use data

Signed-off-by: Liu Qi <lingjiujianke(a)gmail.com>
---
arch/cris/arch-v32/kernel/signal.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/cris/arch-v32/kernel/signal.c
b/arch/cris/arch-v32/kernel/signal.c
index 0b7e3f1..dd69fb4 100644
--- a/arch/cris/arch-v32/kernel/signal.c
+++ b/arch/cris/arch-v32/kernel/signal.c
@@ -656,6 +656,9 @@ int __init
cris_init_signal(void)
{
u16* data = kmalloc(PAGE_SIZE, GFP_KERNEL);
+ if(!data){
+ printk(KERN_ERR "kmalloc memory failed in %s \n", __func__);
+ return -ENOMEM;
+ }

/* This is movu.w __NR_sigreturn, r9; break 13; */
data[0] = 0x9c5f;
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/