From: Geert Uytterhoeven on
2010/5/27 Toralf Förster <toralf.foerster(a)gmx.de>:
> I bisected it to this :
>
> There are only 'skip'ped commits left to test.
> The first bad commit could be any of:
> 4677d4a53e0d565742277e8913e91c821453e63e
> d61931d89be506372d01a90d1755f6d0a9fafe2d
> 1527bc8b928dd1399c3d3467dd47d9ede210978a
> c59bd5688299cddb71183e156e7a3c1409b90df2
> cb41838bbc4403f7270a94b93a9a0d9fc9c2e7ea
> We cannot bisect more!

For me it crashes even earlier:

ayla$ ./linux
Core dump limits :
soft - 0
hard - NONE
Checking that ptrace can change system call numbers...OK
Checking syscall emulation patch for ptrace...OK
Checking advanced syscall emulation patch for ptrace...OK
Checking for tmpfs mount on /dev/shm...OK
Checking PROT_EXEC mmap in /dev/shm/...OK
Checking for the skas3 patch in the host:
- /proc/mm...not found: No such file or directory
- PTRACE_FAULTINFO...not found
- PTRACE_LDT...not found
UML running in SKAS0 mode
Adding 21749760 bytes to physical memory to account for exec-shield gap
Aborted
ayla$

After fixing the missing/superfluous slab inclusion issues, I bisected
it further to

commit d61931d89be506372d01a90d1755f6d0a9fafe2d
Author: Borislav Petkov <borislav.petkov(a)amd.com>
Date: Fri Mar 5 17:34:46 2010 +0100

x86: Add optimized popcnt variants

Add support for the hardware version of the Hamming weight function,
popcnt, present in CPUs which advertize it under CPUID, Function
0x0000_0001_ECX[23]. On CPUs which don't support it, we fallback to the
default lib/hweight.c sw versions.

A synthetic benchmark comparing popcnt with __sw_hweight64 showed almost
a 3x speedup on a F10h machine.

Signed-off-by: Borislav Petkov <borislav.petkov(a)amd.com>
LKML-Reference: <20100318112015.GC11152(a)aftab>
Signed-off-by: H. Peter Anvin <hpa(a)zytor.com>

I reverted that commit on top of current mainline (and fixed up the
conflicts), and now
it boots again.

CPU is:

processor : 0
vendor_id : GenuineIntel
cpu family : 6
model : 23
model name : Intel(R) Core(TM)2 Quad CPU Q8200 @ 2.33GHz
stepping : 7
cpu MHz : 2003.000
cache size : 2048 KB
physical id : 0
siblings : 4
core id : 0
cpu cores : 4
apicid : 0
initial apicid : 0
fpu : yes
fpu_exception : yes
cpuid level : 10
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov
pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx
lm constant_tsc arch_perfmon pebs bts rep_good aperfmperf pni dtes64
monitor ds_cpl est tm2 ssse3 cx16 xtpr pdcm sse4_1 lahf_lm
bogomips : 4665.87
clflush size : 64
cache_alignment : 64
address sizes : 36 bits physical, 48 bits virtual
power management:

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Geert Uytterhoeven on
On Sun, May 30, 2010 at 13:39, Geert Uytterhoeven <geert(a)linux-m68k.org> wrote:
> 2010/5/27 Toralf Förster <toralf.foerster(a)gmx.de>:
>> I bisected it to this :

> After fixing the missing/superfluous slab inclusion issues, I bisected
> it further to
>
> commit d61931d89be506372d01a90d1755f6d0a9fafe2d
> Author: Borislav Petkov <borislav.petkov(a)amd.com>
> Date:   Fri Mar 5 17:34:46 2010 +0100
>
>    x86: Add optimized popcnt variants
>
>    Add support for the hardware version of the Hamming weight function,
>    popcnt, present in CPUs which advertize it under CPUID, Function
>    0x0000_0001_ECX[23]. On CPUs which don't support it, we fallback to the
>    default lib/hweight.c sw versions.
>
>    A synthetic benchmark comparing popcnt with __sw_hweight64 showed almost
>    a 3x speedup on a F10h machine.
>
>    Signed-off-by: Borislav Petkov <borislav.petkov(a)amd.com>
>    LKML-Reference: <20100318112015.GC11152(a)aftab>
>    Signed-off-by: H. Peter Anvin <hpa(a)zytor.com>
>
> I reverted that commit on top of current mainline (and fixed up the
> conflicts), and now
> it boots again.

I tried adding

config ARCH_HWEIGHT_CFLAGS
string
default "-fcall-saved-ecx -fcall-saved-edx" if !64_BIT
default "-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx
-fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10
-fcall-saved-r11" if 64_BIT

to arch/um/Kconfig.x86. Now it got a bit further, but it still crashes:

Core dump limits :
soft - 0
hard - NONE
Checking that ptrace can change system call numbers...OK
Checking syscall emulation patch for ptrace...OK
Checking advanced syscall emulation patch for ptrace...OK
Checking for tmpfs mount on /dev/shm...OK
Checking PROT_EXEC mmap in /dev/shm/...OK
Checking for the skas3 patch in the host:
- /proc/mm...not found: No such file or directory
- PTRACE_FAULTINFO...not found
- PTRACE_LDT...not found
UML running in SKAS0 mode
Adding 22290432 bytes to physical memory to account for exec-shield gap
Linux version 2.6.34-08406-g52b0ace-dirty (geert(a)ayla) (gcc version
4.4.3 (Ubuntu 4.4.3-4ubuntu5) ) #41 Sun May 30 13:54:35 CEST 2010
Built 1 zonelists in Zone order, mobility grouping on. Total pages: 70007
Kernel command line: ubd0=/home/uml/rootfs-amd64
eth0=slirp,,slirp-fullbolt mem=256M root=98:0
PID hash table entries: 2048 (order: 2, 16384 bytes)
Dentry cache hash table entries: 65536 (order: 7, 524288 bytes)
Inode-cache hash table entries: 32768 (order: 6, 262144 bytes)
Memory: 250720k available
Hierarchical RCU implementation.
Verbose stalled-CPUs detection is disabled.
NR_IRQS:15
Calibrating delay loop... 419.43 BogoMIPS (lpj=2097152)
pid_max: default: 32768 minimum: 301
Mount-cache hash table entries: 256
Checking that host ptys support output SIGIO...Yes
Checking that host ptys support SIGIO on close...No, enabling workaround
Using 2.6 host AIO
NET: Registered protocol family 16
bio: create slab <bio-0> at 0
Switching to clocksource itimer
NET: Registered protocol family 2
IP route cache hash table entries: 4096 (order: 3, 32768 bytes)
TCP established hash table entries: 16384 (order: 6, 262144 bytes)
TCP bind hash table entries: 16384 (order: 5, 131072 bytes)
TCP: Hash tables configured (established 16384 bind 16384)
TCP reno registered
UDP hash table entries: 256 (order: 1, 8192 bytes)
UDP-Lite hash table entries: 256 (order: 1, 8192 bytes)
NET: Registered protocol family 1
mconsole (version 2) initialized on /home/geert/.uml/z9aGEj/mconsole
Checking host MADV_REMOVE support...OK
VFS: Disk quotas dquot_6.5.2
Dquot-cache hash table entries: 512 (order 0, 4096 bytes)
msgmni has been set to 489
io scheduler noop registered
io scheduler deadline registered
io scheduler cfq registered (default)
TCP cubic registered
NET: Registered protocol family 17
Initialized stdio console driver
Console initialized on /dev/tty0
console [tty0] enabled
Initializing software serial port version 1
Choosing a random ethernet address for device eth0
Netdevice 0 (1e:a2:ad:7c:43:91) : SLIRP backend - command line: 'slirp-fullbolt'
console [mc-1] enabled
ubda:
Modules linked in:
Pid: 0, comm: swapper Not tainted 2.6.34-08406-g52b0ace-dirty
RIP: 0033:[<0000000060110675>]
RSP: 0000000060235810 EFLAGS: 00010297
RAX: 0000000000000000 RBX: 0000000071371800 RCX: 000000000000000a
RDX: 00000000ffff8aed RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000060235820 R08: 0000000000000000 R09: 000000000000001e
R10: 0000000000000001 R11: 00000000602b8c48 R12: 00000000713c4e80
R13: 00000000713c4e80 R14: 0000000071375958 R15: 0000000000000001
Call Trace:
60235308: [<60014a79>] segv+0x70/0x212
60235318: [<60110675>] cfq_close_cooperator+0x39/0x160
602353e8: [<60014c7a>] segv_handler+0x5f/0x65
60235418: [<60021698>] sig_handler_common+0x84/0x98
602354a0: [<60110675>] cfq_close_cooperator+0x39/0x160
60235548: [<600217de>] sig_handler+0x30/0x3b
60235568: [<60021a10>] handle_signal+0x6d/0xa3
602355b8: [<600233c8>] hard_handler+0x10/0x14
60235678: [<60110675>] cfq_close_cooperator+0x39/0x160
60235708: [<60040bb3>] autoremove_wake_function+0x11/0x34
60235728: [<60040bfe>] wake_bit_function+0x28/0x2e
60235738: [<600276db>] __wake_up_common+0x44/0x7a
60235778: [<60075913>] kmem_cache_free+0x54/0x5f
602357b8: [<60057f6e>] mempool_free_slab+0x12/0x14
602357c8: [<6005803c>] mempool_free+0x6f/0x76
602357f8: [<6009ae62>] bio_free+0x4d/0x52
60235808: [<6011066c>] cfq_close_cooperator+0x30/0x160
60235828: [<60110bae>] cfq_completed_request+0x375/0x4db
60235888: [<601053ee>] elv_completed_request+0x4e/0xaf
602358a8: [<601068be>] __blk_put_request+0x37/0xbd
602358d8: [<60106acf>] blk_finish_request+0x18b/0x198
60235918: [<60106d85>] blk_end_bidi_request+0x38/0x4b
60235948: [<60106dca>] blk_end_request+0xb/0xd
60235958: [<6001cf86>] ubd_intr+0x55/0xd7
60235998: [<600527a2>] handle_IRQ_event+0x20/0x9a
602359c8: [<60052889>] __do_IRQ+0x6d/0xb0
602359f8: [<6001217f>] do_IRQ+0x27/0x3f
60235a28: [<6001234f>] sigio_handler+0x4b/0x5f
60235a48: [<60021698>] sig_handler_common+0x84/0x98
60235a68: [<60021745>] real_alarm_handler+0x3c/0x3e
60235af0: [<60095b01>] copy_fs_struct+0xc/0x76
60235b78: [<600217de>] sig_handler+0x30/0x3b
60235b98: [<60021a10>] handle_signal+0x6d/0xa3
60235be8: [<600233c8>] hard_handler+0x10/0x14

Kernel panic - not syncing: Segfault with no mm
Call Trace:
60235218: [<6018fadb>] panic+0xe4/0x14f
60235278: [<6004db6b>] is_module_text_address+0x9/0x11
60235288: [<6003ecdc>] __kernel_text_address+0x65/0x6b
60235290: [<600233c8>] hard_handler+0x10/0x14
602352a8: [<60013a12>] show_trace+0x8e/0x95
602352d8: [<60026e34>] show_regs+0x2b/0x2f
60235308: [<60014b03>] segv+0xfa/0x212
60235318: [<60110675>] cfq_close_cooperator+0x39/0x160
602353e8: [<60014c7a>] segv_handler+0x5f/0x65
60235418: [<60021698>] sig_handler_common+0x84/0x98
602354a0: [<60110675>] cfq_close_cooperator+0x39/0x160
60235548: [<600217de>] sig_handler+0x30/0x3b
60235568: [<60021a10>] handle_signal+0x6d/0xa3
602355b8: [<600233c8>] hard_handler+0x10/0x14
60235678: [<60110675>] cfq_close_cooperator+0x39/0x160
60235708: [<60040bb3>] autoremove_wake_function+0x11/0x34
60235728: [<60040bfe>] wake_bit_function+0x28/0x2e
60235738: [<600276db>] __wake_up_common+0x44/0x7a
60235778: [<60075913>] kmem_cache_free+0x54/0x5f
602357b8: [<60057f6e>] mempool_free_slab+0x12/0x14
602357c8: [<6005803c>] mempool_free+0x6f/0x76
602357f8: [<6009ae62>] bio_free+0x4d/0x52
60235808: [<6011066c>] cfq_close_cooperator+0x30/0x160
60235828: [<60110bae>] cfq_completed_request+0x375/0x4db
60235888: [<601053ee>] elv_completed_request+0x4e/0xaf
602358a8: [<601068be>] __blk_put_request+0x37/0xbd
602358d8: [<60106acf>] blk_finish_request+0x18b/0x198
60235918: [<60106d85>] blk_end_bidi_request+0x38/0x4b
60235948: [<60106dca>] blk_end_request+0xb/0xd
60235958: [<6001cf86>] ubd_intr+0x55/0xd7
60235998: [<600527a2>] handle_IRQ_event+0x20/0x9a
602359c8: [<60052889>] __do_IRQ+0x6d/0xb0
602359f8: [<6001217f>] do_IRQ+0x27/0x3f
60235a28: [<6001234f>] sigio_handler+0x4b/0x5f
60235a48: [<60021698>] sig_handler_common+0x84/0x98
60235a68: [<60021745>] real_alarm_handler+0x3c/0x3e
60235af0: [<60095b01>] copy_fs_struct+0xc/0x76
60235b78: [<600217de>] sig_handler+0x30/0x3b
60235b98: [<60021a10>] handle_signal+0x6d/0xa3
60235be8: [<600233c8>] hard_handler+0x10/0x14


Modules linked in:
Pid: 0, comm: swapper Not tainted 2.6.34-08406-g52b0ace-dirty
RIP: 0000:[<0000000000000000>]
RSP: 0000000000000000 EFLAGS: 00000000
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
Call Trace:
602351a8: [<60014de7>] panic_exit+0x2f/0x45
602351b0: [<600233c8>] hard_handler+0x10/0x14
602351c8: [<600441ea>] notifier_call_chain+0x32/0x5e
60235208: [<60044230>] atomic_notifier_call_chain+0xf/0x11
60235218: [<6018faf6>] panic+0xff/0x14f
60235278: [<6004db6b>] is_module_text_address+0x9/0x11
60235288: [<6003ecdc>] __kernel_text_address+0x65/0x6b
60235290: [<600233c8>] hard_handler+0x10/0x14
602352a8: [<60013a12>] show_trace+0x8e/0x95
602352d8: [<60026e34>] show_regs+0x2b/0x2f
60235308: [<60014b03>] segv+0xfa/0x212
60235318: [<60110675>] cfq_close_cooperator+0x39/0x160
602353e8: [<60014c7a>] segv_handler+0x5f/0x65
60235418: [<60021698>] sig_handler_common+0x84/0x98
602354a0: [<60110675>] cfq_close_cooperator+0x39/0x160
60235548: [<600217de>] sig_handler+0x30/0x3b
60235568: [<60021a10>] handle_signal+0x6d/0xa3
602355b8: [<600233c8>] hard_handler+0x10/0x14
60235678: [<60110675>] cfq_close_cooperator+0x39/0x160
60235708: [<60040bb3>] autoremove_wake_function+0x11/0x34
60235728: [<60040bfe>] wake_bit_function+0x28/0x2e
60235738: [<600276db>] __wake_up_common+0x44/0x7a
60235778: [<60075913>] kmem_cache_free+0x54/0x5f
602357b8: [<60057f6e>] mempool_free_slab+0x12/0x14
602357c8: [<6005803c>] mempool_free+0x6f/0x76
602357f8: [<6009ae62>] bio_free+0x4d/0x52
60235808: [<6011066c>] cfq_close_cooperator+0x30/0x160
60235828: [<60110bae>] cfq_completed_request+0x375/0x4db
60235888: [<601053ee>] elv_completed_request+0x4e/0xaf
602358a8: [<601068be>] __blk_put_request+0x37/0xbd
602358d8: [<60106acf>] blk_finish_request+0x18b/0x198
60235918: [<60106d85>] blk_end_bidi_request+0x38/0x4b
60235948: [<60106dca>] blk_end_request+0xb/0xd
60235958: [<6001cf86>] ubd_intr+0x55/0xd7
60235998: [<600527a2>] handle_IRQ_event+0x20/0x9a
602359c8: [<60052889>] __do_IRQ+0x6d/0xb0
602359f8: [<6001217f>] do_IRQ+0x27/0x3f
60235a28: [<6001234f>] sigio_handler+0x4b/0x5f
60235a48: [<60021698>] sig_handler_common+0x84/0x98
60235a68: [<60021745>] real_alarm_handler+0x3c/0x3e
60235af0: [<60095b01>] copy_fs_struct+0xc/0x76
60235b78: [<600217de>] sig_handler+0x30/0x3b
60235b98: [<60021a10>] handle_signal+0x6d/0xa3
60235be8: [<600233c8>] hard_handler+0x10/0x14

Kernel panic - not syncing: Kernel mode signal 4
Call Trace:
71040128: [<6018fadb>] panic+0xe4/0x14f
71040218: [<600146ee>]Terminated

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Borislav Petkov on
From: Geert Uytterhoeven <geert(a)linux-m68k.org>
Date: Sun, May 30, 2010 at 01:57:05PM +0200

> On Sun, May 30, 2010 at 13:39, Geert Uytterhoeven <geert(a)linux-m68k.org> wrote:
> > 2010/5/27 Toralf Förster <toralf.foerster(a)gmx.de>:
> >> I bisected it to this :
>
> > After fixing the missing/superfluous slab inclusion issues, I bisected
> > it further to
> >
> > commit d61931d89be506372d01a90d1755f6d0a9fafe2d
> > Author: Borislav Petkov <borislav.petkov(a)amd.com>
> > Date:   Fri Mar 5 17:34:46 2010 +0100
> >
> >    x86: Add optimized popcnt variants
> >
> >    Add support for the hardware version of the Hamming weight function,
> >    popcnt, present in CPUs which advertize it under CPUID, Function
> >    0x0000_0001_ECX[23]. On CPUs which don't support it, we fallback to the
> >    default lib/hweight.c sw versions.
> >
> >    A synthetic benchmark comparing popcnt with __sw_hweight64 showed almost
> >    a 3x speedup on a F10h machine.
> >
> >    Signed-off-by: Borislav Petkov <borislav.petkov(a)amd.com>
> >    LKML-Reference: <20100318112015.GC11152(a)aftab>
> >    Signed-off-by: H. Peter Anvin <hpa(a)zytor.com>
> >
> > I reverted that commit on top of current mainline (and fixed up the
> > conflicts), and now
> > it boots again.
>
> I tried adding
>
> config ARCH_HWEIGHT_CFLAGS
> string
> default "-fcall-saved-ecx -fcall-saved-edx" if !64_BIT
> default "-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx
> -fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10
> -fcall-saved-r11" if 64_BIT
>
> to arch/um/Kconfig.x86. Now it got a bit further, but it still crashes:

Ok, this is a kinda stab in the dark but from what I could decypher
from the include hell, one possible fix should be if UML didn't include
<arch/x86/include/asm/arch_hweight.h> but use the software hweight
version only.

Can you guys check whether the following fixes the issue?

Thanks.

--
diff --git a/arch/x86/include/asm/bitops.h b/arch/x86/include/asm/bitops.h
index 545776e..c9dad12 100644
--- a/arch/x86/include/asm/bitops.h
+++ b/arch/x86/include/asm/bitops.h
@@ -444,7 +444,11 @@ static inline int fls(int x)

#define ARCH_HAS_FAST_MULTIPLIER 1

+#ifdef CONFIG_UML
+#include <asm-generic/bitops/arch_hweight.h>
+#else
#include <asm/arch_hweight.h>
+#endif

#include <asm-generic/bitops/const_hweight.h>


--
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Geert Uytterhoeven on
On Sun, May 30, 2010 at 17:02, Borislav Petkov <bp(a)alien8.de> wrote:
> From: Geert Uytterhoeven <geert(a)linux-m68k.org>
> Date: Sun, May 30, 2010 at 01:57:05PM +0200
>
>> On Sun, May 30, 2010 at 13:39, Geert Uytterhoeven <geert(a)linux-m68k.org> wrote:
>> > 2010/5/27 Toralf Förster <toralf.foerster(a)gmx.de>:
>> >> I bisected it to this :
>>
>> > After fixing the missing/superfluous slab inclusion issues, I bisected
>> > it further to
>> >
>> > commit d61931d89be506372d01a90d1755f6d0a9fafe2d
>> > Author: Borislav Petkov <borislav.petkov(a)amd.com>
>> > Date:   Fri Mar 5 17:34:46 2010 +0100
>> >
>> >    x86: Add optimized popcnt variants
>> >
>> >    Add support for the hardware version of the Hamming weight function,
>> >    popcnt, present in CPUs which advertize it under CPUID, Function
>> >    0x0000_0001_ECX[23]. On CPUs which don't support it, we fallback to the
>> >    default lib/hweight.c sw versions.
>> >
>> >    A synthetic benchmark comparing popcnt with __sw_hweight64 showed almost
>> >    a 3x speedup on a F10h machine.
>> >
>> >    Signed-off-by: Borislav Petkov <borislav.petkov(a)amd.com>
>> >    LKML-Reference: <20100318112015.GC11152(a)aftab>
>> >    Signed-off-by: H. Peter Anvin <hpa(a)zytor.com>
>> >
>> > I reverted that commit on top of current mainline (and fixed up the
>> > conflicts), and now
>> > it boots again.
>>
>> I tried adding
>>
>> config ARCH_HWEIGHT_CFLAGS
>>         string
>>         default "-fcall-saved-ecx -fcall-saved-edx" if !64_BIT
>>         default "-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx
>> -fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10
>> -fcall-saved-r11" if 64_BIT
>>
>> to arch/um/Kconfig.x86. Now it got a bit further, but it still crashes:
>
> Ok, this is a kinda stab in the dark but from what I could decypher
> from the include hell, one possible fix should be if UML didn't include
> <arch/x86/include/asm/arch_hweight.h> but use the software hweight
> version only.
>
> Can you guys check whether the following fixes the issue?

Works, thanks!

BTW, if you want to check yourself:

make ARCH=um defconfig
make ACH=um
./linux

If it panics because it cannot mount the root file system, it works.

> diff --git a/arch/x86/include/asm/bitops.h b/arch/x86/include/asm/bitops.h
> index 545776e..c9dad12 100644
> --- a/arch/x86/include/asm/bitops.h
> +++ b/arch/x86/include/asm/bitops.h
> @@ -444,7 +444,11 @@ static inline int fls(int x)
>
>  #define ARCH_HAS_FAST_MULTIPLIER 1
>
> +#ifdef CONFIG_UML
> +#include <asm-generic/bitops/arch_hweight.h>
> +#else
>  #include <asm/arch_hweight.h>
> +#endif
>
>  #include <asm-generic/bitops/const_hweight.h>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Toralf Förster on

Borislav Petkov wrote at 17:02:14
> Can you guys check whether the following fixes the issue?
>
> Thanks.
>
> --
> diff --git a/arch/x86/include/asm/bitops.h b/arch/x86/include/asm/bitops.h
> index 545776e..c9dad12 100644
> --- a/arch/x86/include/asm/bitops.h
> +++ b/arch/x86/include/asm/bitops.h
> @@ -444,7 +444,11 @@ static inline int fls(int x)
>
> #define ARCH_HAS_FAST_MULTIPLIER 1
>
> +#ifdef CONFIG_UML
> +#include <asm-generic/bitops/arch_hweight.h>
> +#else
> #include <asm/arch_hweight.h>
> +#endif
>
> #include <asm-generic/bitops/const_hweight.h>
>
>
>
solved reported issue.
Thx

--
MfG/Sincerely
Toralf Förster

pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/