Prev: pm_op(): usb_dev_suspend+0x0/0x10 returns -2 on USB device 8087:0020
Next: hp-wmi: Add support for tablet rotation key
From: Dmitry Torokhov on 27 Feb 2010 03:10
On Fri, Feb 26, 2010 at 10:18:38AM -0500, Matthew Garrett wrote:
> dell-laptop currently fails to clean up its platform device correctly.
> Make sure that it's unregistered.
>
> Signed-off-by: Matthew Garrett <mjg(a)redhat.com>
> ---
> drivers/platform/x86/dell-laptop.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index 9d7e0be..b4c2190 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -474,6 +474,10 @@ static void __exit dell_exit(void)
> i8042_remove_filter(dell_laptop_i8042_filter);
> backlight_device_unregister(dell_backlight_device);
> dell_cleanup_rfkill();
> + if (platform_device) {
> + platform_device_del(platform_device);

That should be platform_device_unregister(), otherwise you are missing
final platform_device_put().

> + platform_driver_unregister(&platform_driver);
> + }
> }
>

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: pm_op(): usb_dev_suspend+0x0/0x10 returns -2 on USB device 8087:0020
Next: hp-wmi: Add support for tablet rotation key