Prev: [PATCH -v8 00/24] use lmb with x86
Next: [PATCH 15/24] lmb: Add find_lmb_area_node()
From: Grant Likely on 26 Mar 2010 18:30
On Fri, Mar 26, 2010 at 4:20 PM, Steven J. Magnani
<steve(a)digidescorp.com> wrote:
> On Fri, 2010-03-26 at 15:33 -0600, Grant Likely wrote:
>> On Wed, Mar 17, 2010 at 10:26 AM, Steven J. Magnani
>> <steve(a)digidescorp.com> wrote:
>> > Platform bus attachment for the Xilinx MPMC Soft Direct Memory
>> > Access Controller DMA engine.
>> >
>> > Signed-off-by: Steven J. Magnani <steve(a)digidescorp.com>
>> > ---
>> > diff -uprN a/drivers/dma/xlldma_plat.c b/drivers/dma/xlldma_plat.c
>> > --- a/drivers/dma/xlldma_plat.c 1969-12-31 18:00:00.000000000 -0600
>> > +++ b/drivers/dma/xlldma_plat.c 2010-03-17 11:11:16.000000000 -0500
>>
>> Not really worth putting into a separate file. �Just put this hunk in
>> the xlldma.c file to keep a few more symbols out of the global
>> namespace.
>
> I can certainly do that, but as someone who's had to add platform bus
> attachments to drivers that only have OF attachments, I can say from
> experience that the result ends up being rather messy. I thought
> (explicitly) decoupling the bus logic from the driver might be an
> improvement. Maybe it's not enough of a benefit.

of_platform is geting merged with platform bus so this issue is going
away. Just put it all in one file.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH -v8 00/24] use lmb with x86
Next: [PATCH 15/24] lmb: Add find_lmb_area_node()