Prev: Some fixes for kfifo and FHCI
Next: [PATCH 2/2] als: tsl2550: Remove spurious check against a maximum lux value.
From: Joe Perches on 27 Jan 2010 10:00
On Wed, 2010-01-27 at 10:43 +0100, Jiri Slaby wrote:
> On 01/27/2010 01:37 AM, akpm(a)linux-foundation.org wrote:
> > @@ -3145,7 +3136,9 @@ static inline int raw_cmd_copyout(int cm
> > - COPYOUT(*ptr);
> > + ret = copy_to_user((void __user *)param, ptr, sizeof(*ptr));
> > + if (ret)
> > + return -EFAULT;
[]
> > - COPYIN(*ptr);
> > + ret = copy_from_user(ptr, (void __user *)param, sizeof(*ptr));
>
> Actually the casts are not needed anymore, are they?

There's still some char/void silliness.
It certainly could be improved/removed.

Do feel free to submit patches with your
desired level of changelog prolixity.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Some fixes for kfifo and FHCI
Next: [PATCH 2/2] als: tsl2550: Remove spurious check against a maximum lux value.