drivers/gpu/drm/radeon/radeon_cp.c: check for invalid radeon family
in [Kernel]
|
Prev: [PATCH 2/3][v2] vmstat: add anon_scan_ratio field to zoneinfo
Next: [tip:core/rcu] rcu: Make MAINTAINERS file match new RCU reality
From: walter harms on 13 Jan 2010 04:10 Darren Jenkins schrieb: > If there is an invalid radeon family the fw_name is NULL and causes an > NULL pointer dereference. > This just adds a check for something unexpected. > > Coverity CID: 13252 > > Signed-off-by: Darren Jenkins <darrenrjenkins(a)gmail.com> > diff --git a/drivers/gpu/drm/radeon/radeon_cp.c > b/drivers/gpu/drm/radeon/radeon_cp.c > index 0b2f9c2..1e66337 100644 > --- a/drivers/gpu/drm/radeon/radeon_cp.c > +++ b/drivers/gpu/drm/radeon/radeon_cp.c > @@ -531,6 +531,8 @@ static int > radeon_cp_init_microcode(drm_radeon_private_t *dev_priv) > ((dev_priv->flags & RADEON_FAMILY_MASK) == CHIP_RV570)) { > DRM_INFO("Loading R500 Microcode\n"); > fw_name = FIRMWARE_R520; > + } else { > + return -EINVAL; > } > > err = request_firmware(&dev_priv->me_fw, fw_name, &pdev->dev); > > Someone should take the job to clear the if forrest and replace it with switch()/case. just my 2 cents, wh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |