Prev: btrfs failed to delete reference
Next: sched: Avoid side-effect of tickless idle on update_cpu_load (v2)
From: Jiri Kosina on 17 May 2010 04:30
On Sat, 15 May 2010, Julia Lawall wrote:

> From: Julia Lawall <julia(a)diku.dk>
>
> Use kmemdup when some other buffer is immediately copied into the
> allocated region.
>
> A simplified version of the semantic patch that makes this change is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression from,to,size,flag;
> statement S;
> @@
>
> - to = \(kmalloc\|kzalloc\)(size,flag);
> + to = kmemdup(from,size,flag);
> if (to==NULL || ...) S
> - memcpy(to, from, size);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia(a)diku.dk>
>
> ---
> drivers/hid/hid-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -u -p a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -653,10 +653,9 @@ int hid_parse_report(struct hid_device *
> if (device->driver->report_fixup)
> device->driver->report_fixup(device, start, size);
>
> - device->rdesc = kmalloc(size, GFP_KERNEL);
> + device->rdesc = kmemdup(start, size, GFP_KERNEL);
> if (device->rdesc == NULL)
> return -ENOMEM;
> - memcpy(device->rdesc, start, size);
> device->rsize = size;
>
> parser = vmalloc(sizeof(struct hid_parser));

Applied, thanks Julia.

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: btrfs failed to delete reference
Next: sched: Avoid side-effect of tickless idle on update_cpu_load (v2)